Skip to content

Fix account settings and add seamless deletion and recovery - #73

Merged
Eoic merged 2 commits into
developmentfrom
feat/account-deletion
Oct 23, 2026
Merged

Eoic merged 2 commits into
developmentfrom
feat/account-deletion

Conversation

@Eoic

@Eoic Eoic commented Oct 23, 2026

Copy link
Copy Markdown
Member

Fix account settings so Google reflects the server's linked identities, disable Change password, Two-factor authentication, and Active sessions, and add account deletion with a 30-day recovery window.

Deletion completes from the existing signed-in session using the standard confirmation dialog. Signing in to an account awaiting deletion offers Keep account, which restores access and opens the library without a second login or a success snackbar. The Google recovery page uses the welcome illustration behind the dialog. Token and profile-switch guards prevent late deletion, refresh, or recovery responses from replacing the active account.

Requires server #40. Deploy the server first because this client requires connected_providers in user responses and the new deletion/recovery endpoints. Policy and API documentation: docs #85.

Validation after rebasing onto current development: full Flutter suite passed (1,762 tests, 19 skipped), formatter/analyzer/bootstrap checks passed, and the web build passed. Focused coverage includes deletion/recovery, retries, expired proofs, and server-profile switches. Live provider smoke tests and production deployment were not run.

Related: FR-1_6, UC-1_6. The app shows the 30-day window before confirmation and the deletion date afterward, with the exact dated preview still tracked as a requirement gap.

Copilot AI balanced review requested due to automatic review settings October 23, 2026 13:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T13:14:01.134781Z c001408 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Eoic Eoic self-assigned this Oct 23, 2026
@Eoic
Eoic enabled auto-merge October 23, 2026 13:13

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c001408166

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov

codecov Bot commented Oct 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.59155% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
app/lib/widgets/buttons/google_sign_in.dart 71.42% 2 Missing ⚠️
app/lib/auth/auth_repository.dart 90.90% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Eoic
Eoic merged commit 09646c0 into development Oct 23, 2026
2 checks passed
@Eoic
Eoic deleted the feat/account-deletion branch October 23, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants