Skip to content

Fix page-only PDF navigation in the reader library panel - #98

Merged
Eoic merged 1 commit into
developmentfrom
fix/reader-panel-pdf-locations
Oct 26, 2026
Merged

Eoic merged 1 commit into
developmentfrom
fix/reader-panel-pdf-locations

Conversation

@Eoic

@Eoic Eoic commented Oct 26, 2026

Copy link
Copy Markdown
Member

PDF bookmarks and annotations created through the book-details dialogs can contain a page number without a full reader locator. The reader library panel now uses the existing ReaderBookAdapter.savedLocator conversion for those items, so bookmarks navigate directly and annotations offer Go to passage. Exact saved anchors retain their current behavior, and invalid PDF pages or page-only EPUB items remain non-navigable.

Addresses the release review finding. Follow-up to #93/#94, supporting FR-3_4, FR-4_1, and FR-4_2.

Validation: all 18 focused reader-panel and book-adapter tests pass, including new navigation regressions for both saved-item types. Focused Flutter analysis, Dart formatting, and git diff --check pass. Version remains 0.2.0+6.

Copilot AI balanced review requested due to automatic review settings October 26, 2026 22:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T22:52:11.928254Z d2c063d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Eoic
Eoic merged commit 1b51b44 into development Oct 26, 2026
3 checks passed
@Eoic
Eoic deleted the fix/reader-panel-pdf-locations branch October 26, 2026 23:06
@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants