Repository navigation
Reduce fixture overhead and report test phase timings - #55
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Eoic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54. Supports NFR-9_1.
Database tests recreated the entire schema and repeatedly hashed the same fixture password. Create the ordinary schema once, truncate committed rows between tests, cache the fixture hash, and give database-free HTTP routes fixtures that reject accidental database access. Schema-changing migration tests rebuild before and after execution. Real commits and independent sessions remain available to concurrency tests.
Replace acquisition-migration source assertions with an executed downgrade/upgrade/data-preservation check. Move the Pydantic-only sync scenario into a database-free schema test. Remove the auth export assertion, whose symbols are exercised by callers, and the duplicated token-rotation/reuse service scenario already covered through HTTP. Add cleanup regressions for committed writes and committed schema changes followed by failures. Existing ownership, transaction, concurrency, and HTTP error-mapping checks remain. Cancel superseded validation runs. Publish setup/call/teardown totals and slowest phases to the job summary and retain raw timing JSON, including on test failures.
Validation: Ruff, formatting, and Mypy passed. The final full suite passed with 515 tests and 2 intentionally excluded provider-dependent tests. The two additional tests verify timing aggregation and execute a failing pytest subprocess to prove report generation preserves failures and skipped outcomes. A focused set of 32 migration/concurrency/fixture checks also passed. Local full-suite elapsed time decreased from 243.74s to 88.39s with reporting enabled (86.92s before the reporting addition). Workflow linting passed. The first CI run of fixture cleanup reduced the pytest step from a previously observed 309s to 122s. These are single-run observations, not a controlled performance comparison.
Production APIs, database migrations, persisted formats, and versions are unchanged.