Skip to content

Enable managed identity for ASB DLQ custom check #5806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikeminutillo wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −4
Open

Enable managed identity for ASB DLQ custom check #5806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/ServiceControl.Transports.ASBS/DeadLetterQueueCheck.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
using System;
using System.Threading;
using System.Threading.Tasks;
using Azure.Messaging.ServiceBus.Administration;
using Microsoft.Extensions.Logging;
using NServiceBus.CustomChecks;

Expand All @@ -18,9 +17,9 @@ public DeadLetterQueueCheck(TransportSettings settings, ILogger<DeadLetterQueueC
logger.LogDebug("Azure Service Bus Dead Letter Queue custom check starting");

this.logger = logger;
connectionString = settings.ConnectionString;
stagingQueue = $"{settings.EndpointName}.staging";
runCheck = settings.RunCustomChecks;
authenticationMethod = ConnectionStringParser.Parse(settings.ConnectionString).AuthenticationMethod;
}

public override async Task<CheckResult> PerformCheck(CancellationToken cancellationToken = default)
Expand All @@ -31,7 +30,7 @@ public override async Task<CheckResult> PerformCheck(CancellationToken cancellat
}

logger.LogDebug("Checking Dead Letter Queue length");
var managementClient = new ServiceBusAdministrationClient(connectionString);
var managementClient = authenticationMethod.BuildManagementClient();

var queueRuntimeInfo = await managementClient.GetQueueRuntimePropertiesAsync(stagingQueue, cancellationToken);
var deadLetterMessageCount = queueRuntimeInfo.Value.DeadLetterMessageCount;
Expand All @@ -47,9 +46,9 @@ public override async Task<CheckResult> PerformCheck(CancellationToken cancellat
return CheckResult.Pass;
}

readonly string connectionString;
readonly string stagingQueue;
readonly bool runCheck;
readonly AuthenticationMethod authenticationMethod;
readonly ILogger<DeadLetterQueueCheck> logger;
}
}