Skip to content

Do not silently drop findings listed in a baseline inside the scanned tree #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpitjain099 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not silently drop findings listed in a baseline inside the scanned tree #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/pyspector/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,8 @@ def run_wizard():
help="Treat Python SyntaxWarnings as errors and exclude affected files.")
@click.option('--wizard', is_flag=True,
help="Launch interactive guided scan mode — ideal for first-time users.")
@click.option('--no-baseline', 'no_baseline', is_flag=True, default=False,
help="Ignore any .pyspector_baseline.json found in the scanned tree.")
@click.option('--stats', 'show_stats', is_flag=True, default=False,
help=(
"Print a detailed performance and findings statistics table "
Expand All @@ -599,6 +601,7 @@ def run_scan_command(
supply_chain: bool,
syntax_warnings: bool,
wizard: bool,
no_baseline: bool,
show_stats: bool,
debug: bool,
show_msg: Optional[bool],
Expand Down Expand Up @@ -685,6 +688,7 @@ def run_scan_command(
report_format, severity_level, ai_scan,
supply_chain,
syntax_warnings, show_stats, debug,
no_baseline=no_baseline,
)
except subprocess.CalledProcessError as e:
click.echo(
Expand All @@ -708,6 +712,7 @@ def run_scan_command(
report_format, severity_level, ai_scan,
supply_chain,
syntax_warnings, show_stats, debug,
no_baseline=no_baseline,
)


Expand All @@ -722,6 +727,7 @@ def _execute_scan(
syntax_warnings: bool = False,
show_stats: bool = False,
debug: bool = False,
no_baseline: bool = False,
):
"""
Core scan orchestrator.
Expand Down Expand Up @@ -758,7 +764,9 @@ def _execute_scan(
else scan_path.parent / ".pyspector_baseline.json"
)
ignored_fingerprints: set = set()
if baseline_path.exists():
if no_baseline and baseline_path.exists():
_dbg(debug, f"[*] Ignoring baseline '{baseline_path}' (--no-baseline).")
elif baseline_path.exists():
try:
with baseline_path.open('r') as f:
baseline_data = json.load(f)
Expand Down Expand Up @@ -906,6 +914,17 @@ def _execute_scan(
_severity_filtered = len(raw_issues) - len(severity_passed)
_baseline_ignored = len(severity_passed) - len(final_issues)

# The baseline is read from inside the tree being scanned, so when that tree
# came from somewhere else the file that suppressed these findings did too.
# Say so unconditionally rather than only under --stats, so a scan can never
# report clean while quietly dropping results.
if _baseline_ignored:
click.echo(click.style(
f"[!] {_baseline_ignored} finding(s) suppressed by "
f"'{baseline_path}'. Use --no-baseline to ignore it.",
fg="yellow"
))

if stats:
stats.record_final_issues(
final_issues,
Expand Down