Fix Supreme Ego Reservation rounding - #10255
Open
LocalIdentity wants to merge 2 commits into
Open
Conversation
The client keeps flat reservation and percentage reservation in integer units while applying increased reservation, resource-specific final reservation, and generic final reservation as separate stages. PoB previously multiplied the combined floating-point modifiers and rounded only once. We now track the two final reservation multipliers separately, truncate each intermediate stage, retain percentage reservation in permyriad until the final result, and round only after efficiency. Added a Clarity test where 34 with two 50% final stages becomes 76 rather than 77.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The client keeps flat reservation and percentage reservation in integer units while applying increased reservation, resource-specific final reservation, and generic final reservation as separate stages.
PoB previously multiplied the combined floating-point modifiers and rounded only once.
We now track the two final reservation multipliers separately, truncate each intermediate stage, retain percentage reservation in permyriad until the final result, and round only after efficiency.
Added a Precision test where the reservation is 30 instead of 31
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/ff2bu60h
Before screenshot:
After screenshot: