Skip to content

Fix tsgo snapshot API client and type-check diagnostics - #12830

Merged
proggeramlug merged 3 commits into
mainfrom
codex/tsg-tsgo-api
Oct 18, 2026
Merged

proggeramlug merged 3 commits into
mainfrom
codex/tsg-tsgo-api

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

perry --type-check sends length-prefixed string tuples to native-preview, which expects immediate binary tuples. It then calls the removed loadProject API, so checking is disabled even for small projects.

Use the verified 7.0.0-dev.20260612.1 protocol: initialize, updateSnapshot, snapshot/project-aware batch queries, and typeToString for returned handles. Correct native TypeFlags and SWC source offsets. Configuration, syntax and semantic errors now fail compilation. Missing or unsupported checkers retain warning-and-continue behavior. Because the preview protocol has no version handshake, reject unverified executable versions before IPC.

Validation on head 3bf28ac92479b9fe2b58b112720f9b142453b0e4:

  • Matching release compiler/archives and GC-effects sidecars passed.
  • Five scoped unit tests passed, including real snapshot/source/type handles, Unicode offsets, native flags, typed errors and large/malformed frames.
  • Three CLI integration tests passed: real pinned-tsgo 10/300-file clean/error projects matching standalone diagnostics and Node v26.8.1, plus missing/old/new checker fallback. Real-checker tests are opt-in and install nothing in CI.
  • Final pmcheck.sh passed build, sidecars, zod/tsc smoke and scoped unit tests.
  • Native instructions:u medians (n=3, both arms on qb7): 10 files −0.0104%; 300 files +0.0130%. Both .text sizes unchanged. Perrymaster wall/RSS and parity completed.
  • Targeted formatting, diff checks and Node-version consistency passed. The global file-size check has 19 pre-existing violations outside this diff; this change adds none.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug
proggeramlug marked this pull request as ready for review October 18, 2026 16:13
@proggeramlug
proggeramlug merged commit 5cbce50 into main Oct 18, 2026
90 of 94 checks passed
@proggeramlug
proggeramlug deleted the codex/tsg-tsgo-api branch October 18, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant