Repository navigation
Fix type errors and run type checks in CI - #11
Merged
Merged
Conversation
Annotate the hand-written modules so mypy, strict mypy on src, pyrefly, and ty all pass on Python 3.12 and 3.14. Generated models already passed. Add typecheck to `just check` and a CI job for both Python versions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chrisjkuch
force-pushed
the
fix-typechecking
branch
from
November 18, 2026 06:59
b4a1af1 to
85457c0
Compare
…tocol - Raise floors to requests>=2.34, urllib3>=2, and faker>=26, the first releases with type information, and type check them in CI with `just typecheck --lowest-direct` on Python 3.12 - Match the typecheck CI job to main's conventions and notify on failure - Keep PageableBundle a Protocol, adding model_validate, so structurally matching bundles still type check - Accept list payloads and UUID keycloak ids in the testing helpers - Test ensure_organization's missing-id error, share one JSON helper in seeding, inline the read-only field set, and add a changelog entry Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jayqi
reviewed
Nov 18, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8. Stacked on #10. Fixes every type error so mypy, strict mypy on
src/, pyrefly, and ty pass, and makes CI enforce them on Python 3.12 with the lowest allowed dependency versions and on Python 3.14 withuv.lock._generated.pyalready passed every checker and needed no codegen changes. The existing drift check plus the type check job means a regenerated file has to type-check tootypechecktojust check, gives the typecheck recipes--lowest-directlikejust test, and adds atypecheckCI job that followsmain's job conventions and is innotify.needsrequests>=2.34,urllib3>=2, andfaker>=26(seeding extra), the first releases that ship type information. Below them, mypy can't see their typesmodel_validateto thePageableBundleProtocol soget_bundle_pagetype-checks, keeping it structural so a caller's own bundle class still matchestransport,errors,testing, andseeding, and replaces baredictwithdict[str, Any]KeycloakClientCredentialsProvider._request_tokenreturns the token and expiry instead of setting them, soget_tokenreturns astrBehavior changes, also in the changelog:
APISession(timeout=...)accepts a floatKeycloakAdmin.ensure_organizationraisesLookupErrorif Keycloak returns no id for a new organization, instead of returning an organization whoseidisNone. New unit test covers itVerification:
just typecheckpasses on 3.14, on 3.12, and on 3.12 with--lowest-direct. Unit tests pass at both resolutionsbundle_type: typeannotation inexchange/pdc/testing.pyshould becometype[PageableBundle]when it upgrades🤖 Generated with Claude Code