Skip to content

feat(mcap,lerobot_v3): carry JointState joint names into info.json - #7

Merged
fdavulcu merged 1 commit into
mainfrom
feat/joint-state-names
Nov 17, 2026
Merged

fdavulcu merged 1 commit into
mainfrom
feat/joint-state-names

Conversation

@fdavulcu

@fdavulcu fdavulcu commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

[written by AI]

Writes the joint names from an MCAP recording's JointState messages into the LeRobot v3 dataset's meta/info.json. The writer wrote "names": null for observation.state and action, so a converted dataset lost which joint each value belongs to.

What changed

  • Reader. For observation.state and action, collects the names each JointState message lists (.name in ROS 2, .joint_names in the Foxglove proto). Values are read by index, so it refuses names that change between messages, and a list without one unique name per value.
  • Model. Episode gains state_names and action_names.
  • Writer. Writes the names into info.json, and refuses an episode whose names disagree with earlier episodes. Unnamed datasets still write null.

Tests

pytest tests/test_mcap_*.py tests/test_lerobot_v3_writer.py: 127 passed.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@fdavulcu
fdavulcu marked this pull request as ready for review November 12, 2026 15:10
@fdavulcu
fdavulcu merged commit 5ae5584 into main Nov 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants