Repository navigation
fix: let Hermes's install scan accept the plugin (0.3.1) - #16
Merged
Merged
Conversation
… plugin Hermes's plugin scanner flags `NONO_PHANTOM_TOKEN = "nono-phantom-github-app"` as a hardcoded secret (critical, not overridable with --force) and refuses to install 0.3.0. Rename it to NONO_PLACEHOLDER (same value; the old name stays as an alias) and add a regression test running the scanner's rule over the shipped files. Bump to 0.3.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Hermes refuses to install 0.3.0. Its install-time security scan (
tools/skills_guard.py, rulehardcoded_secret) flags this line inconfig.py:The rule matches any name ending in
token,secret,passwordorapi_key, assigned a quoted string of 20 or more characters. It reports a hardcoded secret with severity critical, which gives the plugin the verdictdangerous.hermes plugins install --forcecannot override adangerousverdict:The value is only the token-broker placeholder, but no agent can install 0.3.0.
What
NONO_PLACEHOLDER, keeping the same value.NONO_PHANTOM_TOKENstays as an alias assigned from it, so existing imports keep working; the scanner only matches quoted literals.tests/test_install_scan.py, which runs the scanner's rule over the shipped files and fails if any line matches.Testing
ruff format --check,ruff check,mypyandpytest(37 tests) pass. The new test fails against the 0.3.0 sources.Hermes's own
scan_skillon a clone of each ref:0.3.0: verdictdangerous, 1 critical (config.py:17);caution, 0 critical.The remaining medium findings are in
.github/workflows/cd.yamland were already in 0.2.0, which installs fine.