Repository navigation
Pass IPv6 TCP packets to tcp6 gro_receive in homa_hijack_gro_receive - #138
Open
randomizedcoder wants to merge 1 commit into
Open
randomizedcoder wants to merge 1 commit into
randomizedcoder wants to merge 1 commit into
Conversation
* homa_hijack_gro_receive is installed for both inet_offloads and inet6_offloads, but always passed non-Homa packets to the IPv4 TCP gro_receive, so IPv6 TCP packets went through tcp4_gro_receive (which treats the IPv6 header as an iphdr). homa_hijack_init runs at module load, so this affects all IPv6 TCP traffic. * Use the saved tcp6_net_offload for IPv6 packets. * Pin the existing pass-through test to IPv4 (it relied on the default) and add an IPv6 one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
homa_hijack_gro_receiveis installed in bothinet_offloadsandinet6_offloads, but always passed non-Homa packets to the IPv4 TCPgro_receive;tcp6_net_offloadwas saved and never used. IPv6 TCP packets therefore went throughtcp4_gro_receive, which treats the IPv6 header as aniphdr.homa_hijack_initruns at module load, so this affects all IPv6 TCP traffic on a host with Homa loaded.tcp6_net_offloadfor IPv6 packets.homa_hijack_gro_receive__pass_to_tcp_ipv6(the fixture already installsunit_tcp6_gro_receive, which nothing expected). The existing pass-through test relied on the default address family; it is pinned to IPv4 and renamed__pass_to_tcp_ipv4to match__pass_to_homa_ipv4/ipv6.Verified: the new test fails before the fix and passes after; full unit suite 885/885 in both IPv6 and
--ipv4modes;homa.kocompiles warning-free on 7.3, normal and__STRIP__=1; checkpatch clean.🤖 Generated with Claude Code