Repository navigation
Advance next_qdisc in homa_qdisc_destroy - #140
Open
randomizedcoder wants to merge 1 commit into
Open
randomizedcoder wants to merge 1 commit into
randomizedcoder wants to merge 1 commit into
Conversation
* homa_qdisc_xmit_deferred_tcp keeps a round-robin cursor, qdev->next_qdisc, that can point at a qdisc's defer_links. homa_qdisc_destroy unlinked the qdisc without moving the cursor, so if other qdiscs still had deferred packets the pacer would next use the destroyed (and soon freed) qdisc. * Move the cursor past the qdisc before unlinking it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
randomizedcoder
added a commit
to randomizedcoder/HomaModule
that referenced
this pull request
Oct 29, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
homa_qdisc_xmit_deferred_tcpkeeps a round-robin cursor,qdev->next_qdisc, that can point at a qdisc'sdefer_links.homa_qdisc_destroyunlinked the qdisc without moving the cursor, so if other qdiscs on the device still had deferred TCP packets, the pacer would next use the destroyed (and then freed) qdisc: a use-after-free, or a NULL skb from its now-empty queue. Reached by replacing or deleting one queue's qdisc while TCP packets are deferred on others.homa_qdisc_destroy__advance_next_qdisc.Verified: the new test fails before the fix and passes after; full unit suite 885/885 in both IPv6 and
--ipv4modes;homa.kocompiles warning-free on 7.3, normal and__STRIP__=1; checkpatch clean.🤖 Generated with Claude Code