Reduce ClickHouse lookup memory use and scan time - #966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClickHouse compatibility views converted binary strings into
Array(Int8)values one byte at a time. A rollback lookup could allocate several gigabytes before it returned any rows. The views also wrapped location columns inifexpressions, which caused spatial lookups to scan more data than needed.This PR upgrades the ClickHouse JDBC driver to 0.10.0 and enables its binary string support. CoreProtect can now read binary columns as raw bytes without building per-byte arrays in ClickHouse.
Location inspectors now read
event_data FINALdirectly. They filter the storedfamily,wid,x, andzcolumns, which match the start of the table sorting key. Compatibility views also project stored location columns withoutifwrappers.Union queries now use numeric
tblvalues. This preventsResultSet.getInt("tbl")from failing with the newer JDBC driver.Testing
mvn -DskipTests package.Fixes #965