Skip to content

fix(people): accept unknown Telegram group admins in the Capo area - #134

Merged
toto04 merged 1 commit into
mainfrom
fix/people-unknown-group-admins
Oct 26, 2026
Merged

toto04 merged 1 commit into
mainfrom
fix/people-unknown-group-admins

Conversation

@BIA3IA

@BIA3IA BIA3IA commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Backend PoliNetworkOrg/backend#93 (RFC v3 Phase 6) drops tg_group_admins. Group admins are native Telegram status (RFC v3 decision 2), which the backend does not store, so capo.get now returns admins: null for each group.

  • Contract: capoAreaSchema accepted only a number, so Telegram › Capo Admin would fail to load once fix(ui): polish desktop and mobile layouts and simplify copy #93 is deployed. admins is now number | null.
  • Capo page: an unknown count shows neither a count nor the "No admins" badge. The badge stays for a known count of zero.

Order

Backward compatible: numbers are still accepted. Merge before or together with backend #93.

Verification

  • pnpm run typecheck: OK.
  • vp check: 0 errors (the 28 warnings are already on main).
  • pnpm run test: 199 passed, including a new test that the Capo area accepts admins: null.

Backend PoliNetworkOrg/backend#93 drops tg_group_admins (RFC v3 Phase 6).
Group admins are native Telegram status, which the backend does not
store, so the Capo area now reports `admins: null` per group.

The contract accepted only a number, so the page would fail to load.
A null count is now accepted and shows neither a count nor the
"No admins" badge, which stays for a known count of zero.
@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 11db91b6-156e-4749-b719-ff0f9d58db9b
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@toto04
toto04 merged commit 68031ef into main Oct 26, 2026
2 checks passed
@toto04
toto04 deleted the fix/people-unknown-group-admins branch October 26, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants