Repository navigation
Enforce Pyright for the simulation gateway and executor - #875
Merged
Merged
Conversation
This was referenced Oct 21, 2026
anth-volk
force-pushed
the
pyright-enforce
branch
from
October 21, 2026 16:21
616d4f1 to
bab8a22
Compare
anth-volk
force-pushed
the
pyright-enforce
branch
from
October 21, 2026 16:30
bab8a22 to
9da0557
Compare
2 tasks done
anth-volk
force-pushed
the
pyright-enforce
branch
from
October 21, 2026 16:59
9da0557 to
e87022e
Compare
anth-volk
force-pushed
the
pyright-enforce
branch
2 times, most recently
from
October 21, 2026 21:37
85e560d to
b0c9a63
Compare
anth-volk
force-pushed
the
pyright-enforce
branch
from
October 21, 2026 22:21
b0c9a63 to
26ba68a
Compare
anth-volk
force-pushed
the
pyright-enforce
branch
from
October 22, 2026 13:22
26ba68a to
bfa52b2
Compare
anth-volk
force-pushed
the
pyright-enforce
branch
from
October 22, 2026 17:16
bfa52b2 to
133c4d0
Compare
anth-volk
force-pushed
the
pyright-enforce
branch
2 times, most recently
from
October 26, 2026 12:01
5cfaa88 to
9543869
Compare
anth-volk
force-pushed
the
pyright-enforce
branch
2 times, most recently
from
October 26, 2026 12:55
eb6bef0 to
9ff4573
Compare
Their proofs compared a recorded report with a fixture baseline. With no errors left, each proof now checks what an enforced rule allows: the bad fixture is the package's real report from before its fixes (main at ceb30e1), which fails with every error new, and the good fixture is a clean report recorded from the fixed package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both packages have no Pyright errors, so sim.quality.pyright-gateway and sim.quality.pyright-executor move from ratcheted to enforced, and their empty baselines go. apis-integ stays ratcheted at 4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The proof comments called the bad fixtures the packages' real errors before their fixes; they are three-error excerpts of those 81- and 178-error reports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anth-volk
force-pushed
the
pyright-enforce
branch
from
October 26, 2026 13:04
9ff4573 to
bb70f35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #874
Same-Repository Draft PR Check
PolicyEngine/policyengine-sim-api, not a personal fork.Summary
Sixth in the Pyright stack, on top of #873. With the gateway (#866) and the executor (#869, #871, #873) at zero Pyright errors, their rules move from ratcheted to enforced, and their empty baselines are deleted:
sim.quality.pyright-gatewayrules/baselines/pyright-gateway.txt(0 entries)sim.quality.pyright-executorrules/baselines/pyright-executor.txt(0 entries)sim.quality.pyright-apis-integThe rules guard treats ratcheted to enforced as a tightening, so no downgrade reason is needed.
Commits (red, then green)
Prove the gateway and executor Pyright rules as enforced rules. The proofs now check what an enforced rule allows. Each bad fixture is the package's real report from
mainat ceb30e1, unchanged; it now fails with every error new and no baseline. Each good fixture is a clean report recorded from the fixed package. Red: the rewritten proof tests failed against the old ratchet fixtures. Green: they pass once the fixture baselines are removed and the clean reports recorded. The guard and the rules-tool tests pass at this commit alone (checked in a separate checkout).Enforce Pyright for the gateway and executor, and drop their baselines. Red: deleting the baseline files made the guard fail with
baseline file ... does not exist. Green: with both rules enforced, the guard, the rules-tool tests andpython -m scripts.rules pyrightpass (gateway and executor "passed with no Pyright errors", apis-integ 4 listed).Say the gateway and executor proofs use excerpts of the real reports. Comment-only, from the review; the proof tests pass.
Suppressions added
None.
Real bugs found
None.
Self-review
review-codeon this PR's diff, run by a separate agent, found no bugs. Findings:[rule.downgrade] reason.Environment variables
No CI, image or deployment changes.
Testing
python -m unittest discover -s scripts/rules/tests -t .: pass.python scripts/run_quality_guards.pyandpython -m scripts.rules guard --base-ref pyright-executor-remainder: pass.python -m scripts.rules pyright: all eight packages pass.#873 merged on 2026-10-26, so this PR is now the bottom of the stack and its CI runs in full.
🤖 Generated with Claude Code