Repository navigation
Conversation
…the rest The harness gate runs tests/Arch.php since pollora/harness 0.1.20, and the framework's floating ^0.1.15 constraint picked it up: develop and main went red on 12 architecture tests that CI never ran before. Fixed: CONV-05 (env() in the plugin and theme modules), CONV-07 (resolve() in PluginManager and ThemeManager), ARCH-03 for Route (the type resolver interface moves to the domain, the old name stays as an alias), Schedule and VersionCheck (new VersionSourceResolver contract). Exempted with a reason and capped by the ratchet: ARCH-01 and ARCH-03 for the Modules, Plugin and Theme application layers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
developandmainare red since the harness started runningtests/Arch.php(pollora/harness 0.1.20). The framework requires^0.1.15, so the scheduled run of 5 November installed 0.1.22 on the same commit that was green on 4 November (0.1.19). Twelve architecture tests failed; none of them is caused by a recent change, CI never ran those rules before.Fixed
LaravelPluginModuleandLaravelThemeModulereadVAPOR_MAINTENANCE_MODEwithIlluminate\Support\Env::get()(whatenv()calls) instead ofenv(); the two PHPStan baseline entries for it go away (baseline 58 → 56)PluginManagerandThemeManagerread the console detection service from the container they receive, not fromresolve()WordPressTypeResolverInterfacemoves toPollora\Route\Domain\Contracts; the former name is aclass_aliasScheduleStatusno longer importsLaravelQueueDriverfor its namePackageVersionCheckerdepends on the newVersionSourceResolvercontract, whichVersionSourcesimplementsExempted (
allow_rules, harness 0.1.23)ModuleCollectionandPluginCollectionextendIlluminate\Support\Collection; they are published classes.Applicationis read as a layer. This needs ports, one module at a time.The scope of an exemption is the whole rule, so the ratchet caps the count (
exempted_rules: 2). The workflow andcomposer.jsonmove to harness 0.1.23.Checks
Full Pest suite: 1645 pass. Two tests fail in the DDEV environment (
it accepts an empty database password,MissingBuildNotice), and they fail the same way on an untoucheddevelop. Pint, PHPStan, Rector and the public surface gate pass.