Repository navigation
Conversation
|
Hey, I know this might not be the behavior that you were looking for, but the behavior you're describing as an issue is actually the intended and better behavior. It is intentional that HUD previews and HUD moving is available in the main mod menu, so users don't have to go back and forth if all they need to do is a quick move, or can avoid an extra click to get to a specific settings menu if not blocked. This PR would actually be seen as a regression. I would not recommend having this PR merged with this current behavior. If there is a legitimate reason why you want this undone, this needs to have further discussion, but quick HUD editing and settings action menus should stay accessible when reachable in the main mod menu. |
|
The current behavior is the intended behavior |
6fea82e to
d7a54ab
Compare
Adds an "Edit HUDs From the Menu" switch to the HUD editor preferences. It is on by default and keeps the current behavior. When turned off, HUDs behind the main OneConfig menu render live like behind any other screen, without previews, outlines or the drag layer, and editing only happens in the HUD editor.
0acbc4b to
11a5dc1
Compare
|
I still think it looks pretty bad having HUD previews and outlines sitting behind the menu, but if that's what you want as the default, that's fine with me. I've reworked the PR so the current behavior stays the default, and added an "Edit HUDs From the Menu" switch under Preferences > HUD Editor. With it on, nothing changes from upstream. With it off, HUDs behind the menu render live like behind any other screen, and editing only happens in the HUD editor. |
|
Ok, the option is fine, and thanks for the rest of that! However... ...how much has this actually been tested? Right away, I'm encountering that you have to exit and re-enter the menu for this to take effect, and even then there are visual discrepancies while toggling.... output.mp4 |
Description
Opening the OneConfig menu (Right Shift) puts every HUD into preview mode, because
HudManager.isEditingisisEditorOpen || isConfigUiOpen. While only the menu is open, every HUD shows demo content, hidden HUDs show at 35% opacity,HudDragLayerdraws outlines and the hover action bar behind the menu, and mods that readisEditing(Chatting, for example) draw their own edit visuals over it.This stays the default. The PR adds an Edit HUDs From the Menu switch under Preferences > HUD Editor so users can opt out.
Changes:
HudManager.previewInConfigUi(internal, synced from the newOneConfigConfig.hudPreviewsInMenuswitch) andHudManager.isConfigUiPreviewing(isConfigUiOpen && previewInConfigUi)isEditing,showingPreviews,OneConfig.prepareHud/submitHudand theOneConfigUIScreenlegacy HUD underlay now checkisConfigUiPreviewinginstead ofisConfigUiOpenHudDragLayerwhile the switch is onisConfigUiOpen, so it works in the menu either wayHudFrameCacheTest.menuWithoutPreviewsKeepsCacheOnchecks that the menu alone keeps the geometry cache on with the switch offhud.apiupdated for the new publicisConfigUiPreviewinggetterCHANGELOG.mdentry under UnreleasedTested in game on 1.8.9 (Ornithe) with the switch on and off.
Related Issue(s)
Checklist
isConfigUiPreviewingtoCHANGELOG.mdunder UnreleasedisEditingreturnsfalsewhile only the menu is open, so mods that use it to show previews behind the menu show live content there insteadNote: on
v1without this change, 4 tests in:modules:hudalready fail for me (HudDeletionPersistenceTest, 3 inHudProfileIsolationTest). They fail the same way with this change.