Skip to content

feat: Hotwire integration stage 1 (internals) - #1392

Draft
lunaynx wants to merge 12 commits into
v1from
feat/hotwire-integration
Draft

lunaynx wants to merge 12 commits into
v1from
feat/hotwire-integration

Conversation

@lunaynx

@lunaynx lunaynx commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Description

Adds backend integration for Hotwire. Does not add a custom UI for it yet.

Drafted while it goes through some review.

Related Issue(s)

Checklist

  • I made a clear description of what was changed
  • I stated why these changes were necessary
  • I updated documentation or said what needs to be updated
  • I made sure these changes are backwards compatible
  • This pull request is for one feature/bug fix

@lunaynx lunaynx mentioned this pull request Nov 20, 2026
@lunaynx
lunaynx force-pushed the feat/hotwire-integration branch 2 times, most recently from 01fd96c to 736d4da Compare November 20, 2026 17:07
@lunaynx
lunaynx force-pushed the v1 branch 4 times, most recently from b223d02 to 6fea82e Compare November 20, 2026 17:51
@lunaynx
lunaynx force-pushed the feat/hotwire-integration branch from 736d4da to 10d28af Compare November 20, 2026 17:52
@lunaynx
lunaynx force-pushed the feat/hotwire-integration branch 4 times, most recently from 39a37d7 to c0bdb9d Compare November 21, 2026 14:12
@lunaynx
lunaynx force-pushed the feat/hotwire-integration branch 2 times, most recently from 1ae3d90 to 657be29 Compare November 21, 2026 23:25
Needs Hotwire 0.9.2 or newer, which is compiled against and not
bundled.
Registering the tree again merged it into itself for a KtConfig, which
builds its tree once, and that cleared the tree and its file.
…t started

Compat told whose config an initializer built from a mod list that did
not have the new mod yet. A start also failed the config entrypoints of
mods whose own start was yet to come in the same update.
…rned on

Their key mappings are out of the game while the mod is off, so a
profile switch in that time left them with the keys of the profile they
went off in, which the next save of the options then stored for the new
profile.
…twire turned on"

Hotwire leaves the key mappings of an off mod in the options, so a
profile switch already reaches them.

This reverts commit 9070f0d.
On a profile without its file, restoring the defaults of a config whose
tree field was reset registered its tree, and the rebind then merged a
KtConfig's tree into itself.
A config whose id has spaces or the like has a tree with another
spelling of it, so its tree was not found and it was reset to its
defaults.
@lunaynx
lunaynx force-pushed the feat/hotwire-integration branch from 20bd7c5 to b99ef85 Compare November 22, 2026 01:20
@lunaynx

lunaynx commented Nov 22, 2026

Copy link
Copy Markdown
Contributor Author

2 Hotwire-side blockers remain, then it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant