Skip to content

fix: brighten stale 1.8.9 light outside the lightmap - #6

Merged
awruff merged 1 commit into
Polyfrost:masterfrom
saadndm:fix/stale-brightness
Nov 19, 2026
Merged

awruff merged 1 commit into
Polyfrost:masterfrom
saadndm:fix/stale-brightness

Conversation

@saadndm

@saadndm saadndm commented Nov 19, 2026

Copy link
Copy Markdown
Member

When theres block placed above head, vanilla sets the sky light under it to 0 and expects a light update to refill it from the sides. Fullbright cancels those updates, and since 59e5315 it no longer overrides light reads (only the lightmap), so it stays stale at 0. This also darkens the brightness of the sky/fog color under blocks

This PR fixes by covering the direct reads the lightmap doesnt apply to.

Release Notes

Fixes some stale 1.8.9 lighting

@awruff
awruff merged commit b2498ab into Polyfrost:master Nov 19, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants