Repository navigation
Fix ruff errors and make the ruff step fail the Lint job - #41
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eliotwrobson
marked this pull request as ready for review
November 11, 2026 06:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Lint job ran ruff with
continue-on-error, so the 131 errors onmainnever failed it. This fixes them and removescontinue-on-error.tests/scenario_root/stand in for student code. They use names the sandbox injects, import inside functions to test import restrictions, and evaluate bare expressions, soF821,PLC0415andB018are ignored there. That covers most of the errors.ruff formatrewrites a#gradecell tag as# grade.json_utils.py:PLC0415is ignored, because numpy and pandas aren't in the lite image.from Noneon a re-raise, split compound asserts,zip(strict=True), anisinstancecheck, import order, andnoqaon the intentionalexecanddill.loads.ruff formatalso joined one line inconfig.py.PT004from the ignore list, because ruff no longer has that rule.There's no branch protection on
main, so the Lint job isn't a required check yet. That has to be set in the repository settings.🤖 Generated with Claude Code