Fix stale repo name in deploy links after GitHub rename - #1225
Open
kylemonette wants to merge 1 commit into
Open
Fix stale repo name in deploy links after GitHub rename#1225kylemonette wants to merge 1 commit into
kylemonette wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utils.pybuilds links in the deploy output from the GitHub repo name/owner parsed out of the local git remote URL.Therefore, if the name of the repository or the owner changes, the links are never updated and may fail: for example,
Your built project will soon be available to the public at: https://johnsmith.github.io/old_repo_namemight not be a valid link if
old_repo_namewas changed after the first deployment.Now it resolves the current name via the GitHub API after parsing the remote, falling back to the locally parsed name if that call fails.