Skip to content

Document the 0.001 minimum of lowerAsymptote - #40

Merged
eliotmcintire merged 1 commit into
developmentfrom
feat/lower-asymptote-min
Nov 14, 2026
Merged

eliotmcintire merged 1 commit into
developmentfrom
feat/lower-asymptote-min

Conversation

@eliotmcintire

Copy link
Copy Markdown
Collaborator

A lower asymptote of 0 is no longer accepted: it is at least 0.001, because with 0 a fire that has not yet reached its minimum size could keep retrying for an unbounded number of generations.

Affects: a ledger row with lowerAsymptote_spread of 0 now stops; documentation only otherwise.

Depends-on: PredictiveEcology/fireSenseUtils#230

Technical details

The check is fireSenseUtils::checkLinkParams() (fireSenseUtils#230, spreadLowerAsymptoteMin = 1e-3); this module already calls it, so the behaviour comes from the package. The fireSense_SpreadPowerLaw output description names the minimum.

Tests: the prediction tests use the minimum instead of 0, and a row with 0 stops with "never 0".

Full suite (module converted with convertToPackage(buildDocuments = TRUE), test_local()): 303 pass, 0 fail, 0 skipped (302 before the change). Scratch library with fireSenseUtils#230 installed.

Reuses: fireSenseUtils::checkLinkParams(), spreadLowerAsymptoteMin; new: nothing.

🤖 Generated with Claude Code

https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6

The check is fireSenseUtils::checkLinkParams(); the tests use the minimum instead of 0 and expect 0 to stop.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
@eliotmcintire eliotmcintire added bug Something isn't working backwards compatible Existing code and results keep working unchanged labels Nov 13, 2026
@eliotmcintire
eliotmcintire merged commit d1de84f into development Nov 14, 2026
9 checks passed
@eliotmcintire
eliotmcintire deleted the feat/lower-asymptote-min branch November 14, 2026 00:57
eliotmcintire added a commit that referenced this pull request Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards compatible Existing code and results keep working unchanged bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant