Skip to content

The Viron address is hardcoded in both entry points #60

Closed

Description

@dmccoystephenson

Observation

The Viron address is fixed in source, in two places since #59: url and port in main.py (lines 25-26) and the same constants in console_view.py. Reaching a Viron on another host or port requires editing both. main() accepts locationService and environmentService arguments, so a program calling it directly can already point elsewhere, but neither command line can. console_view.py cannot import the constants from main.py, since that would pull in Pygame.

Suggested direction

One Pygame-free source for the address, read by both entry points, for example environment variables with the current values as defaults. Any bearer token work for #41 would naturally sit in the same place.

Acceptance criteria

  • Both entry points take the Viron address from one place, with http://localhost:9999 remaining the default.
  • A unit test covers the default and the override.
  • The README's Starting Viron section states how the address is changed.

This issue was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).


drafted by Claude on behalf of Daniel Stephenson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions