Skip to content

The workflow's py_compile step omits text_renderer.py and console_view.py #61

Closed

Description

@dmccoystephenson

Observation

The Check syntax step in .github/workflows/tests.yml names each top-level module, and text_renderer.py and console_view.py from #59 are not among them. Workflow files are on the dev loop's do-not-auto-merge list, so the step was not changed in that PR. The README's Running the tests section currently names the two modules as exceptions.

No coverage is lost, because tests/ imports both modules and a syntax error therefore fails the job. The step is only out of step with the list of modules.

Acceptance criteria

  • python -m py_compile in the workflow names both modules, or the step is changed so that it does not need a list.
  • The exception is removed from the README.

This needs a human to merge, since it modifies .github/workflows/.

This issue was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).


drafted by Claude on behalf of Daniel Stephenson

Activity

  1. dmccoystephenson commented on Nov 7, 2026

    @dmccoystephenson
    MemberAuthor

    PR #62 adds a third module outside the workflow's py_compile list, viron_address.py, and the README's exception now names it as well. If #62 is merged first, the fix for this issue needs to cover all three. Changing the step so that it needs no list would stop this recurring with each new module.

    This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).


    drafted by Claude on behalf of Daniel Stephenson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions