Repository navigation
Document how main.py treats a misplaced flag and extra arguments - #66
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (head
Out-of-diff note: This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runningsection now states that--exit-after-createis recognised only as the second argument. Given first (python main.py --exit-after-create), it is read as an unparseable grid size:Invalid grid size argument, using default of 50.is printed and the render loop is entered. Any other second argument, and every argument after the second, is ignored without a message. This matchesparseArgsinmain.py:43-65.TestParseArgsintests/test_main.py: the flag given first, the flag after the second position, and arguments after the second being ignored. The existingtest_ignores_an_unrecognized_second_argumentalready covered the remaining case.No production code is changed. This is a Stage A documentation sweep; no tracking issue exists — the gap was found during triage.
The usage line
Usage: python main.py [gridSize] [--exit-after-create]could be read as allowing the flag on its own. It is left unchanged here, since changing it is a code change outside a documentation cycle.Skipped issues
Every open issue is waiting on an owner decision, so none was picked this cycle:
environments.jsonshould take for per-server entriesTest plan
python3 -m py_compile *.pypython3 -m unittest discover -s tests— Ran 209 tests, OKTestsworkflow green on this headThis PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson