Repository navigation
ci: rebalance portable serial test shards - #8
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
I'll write the fork grant
Context: that was the captain's answer letting this firstmate open PRs on the captain's fork (Profreshor/firstmate) so the follow-ups from the Codex review on fork PR #3 could ship. One of them, fork PR #7 (Herdr crew scan scope), cannot go green: its "Behavior portable serial 2" job was cancelled twice at the workflow's 30-minute limit. On main the same shard took 29 minutes (run of 2026-10-16 20:41-21:10 UTC) while the other eight shards took 15-20 minutes, so shard 2 is at its limit regardless of PR 7's change.
What Changed
Risk Assessment
✅ Low: Captain: the bounded packing-hint update isolates the measured 25-minute host suite in one serial shard while preserving the existing complete/disjoint coverage checks and 30-minute CI timeout.
Testing
Live execution of the runner produced a passing coverage report with a 1,501,963 ms maximum under the 1,510,000 ms budget and showed the slow host suite alone in shard 1. The focused contract test passed its new exact-budget and one-millisecond-over-budget checks, but later failed an unrelated PTY reparenting fixture; no remote GitHub Actions run was driven in this phase.
Evidence: Portable serial coverage report
Source: Portable serial coverage report
Evidence: Supervision-host shard assignment
Source: Supervision-host shard assignment
Evidence: Focused runner contract test transcript
Source: Focused runner contract test transcript
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
tests/fm-test-run.test.sh- The focused runner contract test reached and passed the changed packing scenarios, then failed an unrelated session-lock fixture because its fake PTY host was not reparented to init after daemon exit. This reproduced on the captured rerun and requires a host/process-namespace environment where orphaned fixture children are adopted as the test expects.bin/fm-test-run.sh --check-coverageEnumeratedbin/fm-test-run.sh --list --lane portable-serial-{1..9}of9to locatefm-supervision-host.test.shtests/fm-test-run.test.sh(focused runner contract; changed packing assertions passed, later unrelated PTY reparenting fixture failed)git diff ba356f1cd9002b3c8432ac8a409baf216f2697c5 | jev find "a change unrelated to raising the portable serial modeled budget and isolating the slow supervision host suite"(no unrelated hunk flagged)✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.