Repository navigation
Move asap_sketchlib to current main - #43
Merged
Merged
Conversation
zzylol
force-pushed
the
chore/sketchlib-main
branch
from
October 20, 2026 23:38
d927134 to
17030ed
Compare
zzylol
force-pushed
the
feat/cardinality-tradeoff-demo
branch
from
October 20, 2026 23:38
67d557c to
ba4d60b
Compare
zzylol
force-pushed
the
chore/sketchlib-main
branch
from
October 20, 2026 23:38
17030ed to
f3c4b28
Compare
zzylol
force-pushed
the
feat/cardinality-tradeoff-demo
branch
2 times, most recently
from
October 20, 2026 23:39
fc4afc4 to
d997227
Compare
zzylol
force-pushed
the
chore/sketchlib-main
branch
2 times, most recently
from
October 20, 2026 23:55
5d672e8 to
57ff866
Compare
zzylol
force-pushed
the
feat/cardinality-tradeoff-demo
branch
from
October 20, 2026 23:55
d997227 to
2eebd74
Compare
zzylol
force-pushed
the
chore/sketchlib-main
branch
from
October 21, 2026 00:02
57ff866 to
ededb1d
Compare
Bump the asap_sketchlib pin from 3fc3442 to 60101c6 and adapt the sketch wrappers and the merge bench to upstream's renames: - CountMin -> CountMinSketch, Count -> CountSketch, CMSHeap -> CountMinSketchWithHeap, HeapItem -> OwnedDataInput, DDSketch -> DdSketch, KLL -> Kll, ErtlMLE -> Ertl - insert / insert_many -> update / update_weighted - serialize_to_bytes / deserialize_from_bytes -> to_asapv1 / from_asapv1 - KLL init_kll / init_kll_with_seed -> with_k / with_k_and_seed The crate already used ASAPv1 only, so no legacy format is involved. Upstream's ASAPv1 changes alter two payloads: DDSketch always writes its negative store and zero count (+3 bytes here), and the Count-Min-with-heap metadata key `k` is now `heap_size` (+8 bytes). The merge-bench byte counts for those two sketches are updated.
zzylol
force-pushed
the
chore/sketchlib-main
branch
from
October 21, 2026 00:17
ededb1d to
b0cf1ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The crate pinned asap_sketchlib at 3fc3442, 11 commits behind main. Upstream has since made ASAPv1 decoding strict, unified the DDSketch encoding, renamed the sketch types and methods (#209), and removed the legacy serialization formats. Staying on the old pin would keep the demo on wire formats and names that no longer exist upstream.
What
How
Renames applied in
src/sketches/{cms,cms_heap,countsketch,ddsketch,hll,kll,mod}.rsandsrc/bin/asap_merge_bench.rs:CountMin→CountMinSketch,Count→CountSketch,CMSHeap→CountMinSketchWithHeap,HeapItem→OwnedDataInput,DDSketch→DdSketch,KLL→Kll,ErtlMLE→Ertl.insert/insert_many→update/update_weighted.serialize_to_bytes/deserialize_from_bytes→to_asapv1/from_asapv1.init_kll/init_kll_with_seed→with_k/with_k_and_seed(the defaultmis still 8).The crate was already ASAPv1-only, so removing the legacy formats changes nothing here. The lockfile no longer pulls in prost or serde-big-array.
Before
After
kis nowheap_size(8,766 → 8,774 bytes). Count-Min, Count Sketch and HLL sizes are unchanged.docs/results/merge-bench.mdand.csvcarry the new byte counts; the timings are still from the original run.Verification
cargo fmt --check,cargo clippy --all-targets --features otap-engine,stream-benchmark -- -D warningsandcargo test --features otap-engine,stream-benchmarkpass on this head (99 + 26 + 11 + 6 + 1 tests). No golden or wire-format tests needed changing.cargo build --release --features collector --bin asap-collectorbuilds. CI runs the scaled acceptance on this head.