Repository navigation
test: ignore tests that plan under a wall-clock budget (#1175) - #1181
Merged
Merged
Conversation
milindsrivastava1997
force-pushed
the
test/ignore-wallclock-flakes
branch
from
November 2, 2026 22:21
42dc57b to
d1f9d1b
Compare
milindsrivastava1997
changed the title
…1175) #1166 and #1180 ignored the tests seen failing on deadlines; every other test that reaches the time-limited search (plan_installable, e2e_plan, optimize, run_planning, or the planner binary) can fail the same way under CI load. Ignore them as a stopgap; #1175 tracks re-enabling or rewriting each once Stage 3's design (#1095, #1067) is final. Tests that only use select_among_plans or installable_plan_of (no deadline) still run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
milindsrivastava1997
force-pushed
the
test/ignore-wallclock-flakes
branch
from
November 2, 2026 22:47
d1f9d1b to
3561228
Compare
milindsrivastava1997
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopgap for planner-test flakiness; #1175 tracks undoing it.
Why
Every planning call runs under a wall-clock budget (30 s default, rounds capped at 5 s, also passed to HiGHS as
time_limit). Under CI load the search stops at a different point or before any plan exists. #1166 and #1180 ignored the tests seen failing that way, but any test that reaches the search is exposed:sql_table_scans::distinct_counts…failed on #1172 today with "execution-scope expansion exceeded the deadline".What
#[ignore = "nondeterministic: plans under a wall-clock budget; revisit after Stage 3 design (#1175)"]. These are every test that reaches the time-limited search, viaplan_installable/e2e_plan/optimize/run_planningor by running the planner binary. The 27 already ignored by test: ignore tests that flake on wall-clock search budgets (#1067) #1166/test: ignore every test whose result depends on a wall-clock budget or deadline (#1067) #1180 keep their attributes.select_among_plans,installable_plan_of) still run (11).Run them with
cargo test --workspace -- --ignored; find them withgrep -rn 'revisit after Stage 3 design' crates.Testing
cargo fmt --checkpasses. Attribute-only change; the full workspace build is left to CI.🤖 Generated with Claude Code