Repository navigation
fix(plan-selection): name the pricing reason when the selection MILP is infeasible - #1189
Closed
milindsrivastava1997 wants to merge 2 commits into
Closed
milindsrivastava1997 wants to merge 2 commits into
milindsrivastava1997 wants to merge 2 commits into
Conversation
…is infeasible Candidates that cannot be priced (e.g. a source with no arrival rate) are dropped before the MILP. When that leaves it infeasible, the rejection said only "infeasible", hiding the missing source fact. The rejection now appends each distinct pricing error. Fixes the DAG viewer test test_a_plan_without_a_rate_fact_names_the_missing_fact, red on main since #1144. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
milindsrivastava1997
force-pushed
the
fix/milp-surface-pricing-reason
branch
from
November 3, 2026 02:29
46a3254 to
7aa529f
Compare
Collaborator
Author
|
Superseded by #1188, which landed the same pricing-reason fix and the selector.rs import fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainhas been red since #1144 because of one test: the DAG viewer'stest_a_plan_without_a_rate_fact_names_the_missing_fact. Since the MILP became Stage 3's search, a workload whose source has no rate fact fails with a bare "infeasible", and the user can't tell which fact is missing. The old engine named it.What / How
Candidates that
asap-costcan't price are dropped before the MILP, and their pricing error is kept inCandidateData::usage. When the MILP is infeasible,selection_errornow appends each distinct pricing error to theInfeasiblerejection's reason.Before this PR
After this PR
Also: unbreak main
maindoes not compile: #1164 importscrate::AnalyticalCostErrorinselector.rs, and #1187, merged before it, moved that import intolib.rs's test module. The second commit imports it fromasap_cost::analyticalinstead.Tests
select::tests::an_unpriceable_workload_names_the_missing_fact: a workload with no source facts names the missing fact. It fails before the fix and passes after.test_server.PlanEndpointTestspasses locally.Key code interfaces added / modified: None (the private
selection_errornow also takes&MilpInputs).Major algorithm changes: None.
🤖 Generated with Claude Code