Repository navigation
Conversation
zzylol
marked this pull request as ready for review
October 24, 2026 20:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
Separate workload enumeration and selection paths repeated equivalent work and represented sharing, materialization, and accuracy decisions inconsistently.
After this PR
One candidate-connection MILP selects a physical execution DAG. P95/P99 retain distinct results while sharing a compatible summary, or selecting separate configurations when appropriate. Legacy selectors and the global Cartesian workload enumerator are removed; modules are organized by candidate generation, costing, MILP, refinement, and pipeline scope.
Supported sharing rules, pane widths, materializations, deployment objectives, recurring execution demand, and retention use the same route. Budget stops retain only validated plans. Internal failures do not silently become fallback results.
Key code interfaces added / modified
CandidateConnectionsroute and phase-level reports, including no-incumbent budget stops.Major algorithm changes
Validation
Complete CI passed on
761a019a:Planning wall time was median 32.37 s, maximum 39.64 s, with peak planner RSS 2.57 GiB on a shared debug-build host running two workloads concurrently. The requested 30-second budget is cooperative; individual calls and cleanup can overrun it. None of these bounded runs proved optimality. Execution costs and accuracy guarantees are evaluator results, not measured stream-execution speedups or empirical error measurements.
Workload evidence and reproduction includes portable phase timings, costs, model sizes, solver status, and binary identity. Explicit-rule tests preserve accuracy, cost, boundary, sharing, and runtime assertions without depending on a timed search archive's visitation order.