Repository navigation
fix(deps): depend on all of asap-planner's frontends - #850
Merged
Merged
Conversation
The backend must support every query language, and ProjectASAP/ASAPPlanner#1065 removes asap-planner's per-frontend features. Drop `default-features = false, features = ["promql"]`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The backend has to support every query language, but since #843 it has built
asap-plannerwith the PromQL frontend only. ProjectASAP/ASAPPlanner#1065 removesasap-planner's per-frontend cargo features, so once that merges, the current dependency line stops resolving at the next rev bump.What and how
Cargo.tomldropsdefault-features = false, features = ["promql"]fromasap-planner. The pinned rev is unchanged.Cargo.lockonly gains packages: DataFusion, the MetricsQL parser and their dependencies. No existing version changes.This PR only links the SQL and MetricsQL frontends. Accepting and planning SQL or MetricsQL workloads in the backend is separate work.
Before this PR
The backend links only
asap-frontend-promql. It cannot plan SQL or MetricsQL.After this PR
The backend links all three frontends and keeps working after the planner change. Builds are longer and the binary is larger, because the backend now compiles DataFusion. Building with
CARGO_BUILD_JOBS=2avoided running out of memory on a dev machine.Testing
cargo test --workspace --locked: 98 passed, 0 failed.🤖 Generated with Claude Code