Repository navigation
Stop the tool install when an archive fails to extract (v2) - #231
Merged
Merged
Conversation
set -e ignores a failure on the left of &&, so a failed tar during an update left the old binary in place, marked with the new checksum. Run the extraction and the move as separate commands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The review reports no active issues with the installer’s archive-extraction failure-handling change.
No open issues 🎉
What changed in this PR
Fixes archive-extraction failure handling in the v2 lint-tool installer, preventing stale binaries from being recorded as successfully updated.
Changes:
- Separates extraction and move commands for
.tar.gzand.tar.xzarchives soset -estops installation if extraction fails. - Adds a comment explaining why chaining these commands with
&&is unsafe.
| File | Description |
|---|---|
scripts/install-tools.sh |
Stops installation on archive-extraction failures before replacing binaries or recording checksums. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue Copilot found on seadrop#229 for v2, since #230 already merged.
scripts/install-tools.shextracted archives withtar ... && mv .... Underset -e, bash ignores a failure on the left of&&, so iftarfailed while updating an installed tool, the script kept the old binary, recorded the new checksum and reported success. Later runs then skipped the stale binary. The extraction and the move are now separate commands, so a failed extraction stops the install.🤖 Generated with Claude Code