Repository navigation
Clarify agent metadata resolution and write permissions - #238
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The central claim about OpenSea’s ERC-8493 resolution remains unverified because its resolver and published guide were inaccessible, although local contracts and tests support the permission and delegation wording.
No open issues 🎉
What changed in this PR
This documentation-only PR clarifies metadata resolution and write permissions in SeaDrop’s agent NFT guide. No contract behavior changes.
Changes:
- Distinguishes explicit ERC-8493
onchain:URI resolution from automatic interpretation of arbitrary ERC-8048 agent records. - Clarifies how authority, owner and holder permissions apply to batch writes.
- Explains delegation behavior across transfers and how current holders clear a delegation.
| File | Description |
|---|---|
| docs/AgentNFTs.md | Clarifies OpenSea metadata resolution, batch write permissions and delegation clearing. |
Review effort: Balanced
|
Verified the resolution claim against the live Metadata storage guide, which returns HTTP 200 and documents both ERC-8048 field reads through onchain: URIs and an onchain: URI returned by tokenURI for the whole JSON document. The backing OnchainUriResolver also implements readDocument and resolve with metadata(tokenId, key). This addresses the external-evidence limitation in Copilot’s review; no additional content change is needed. |
The agent guide incorrectly says OpenSea never reads ERC-8048 records and describes batch writes without the owner/holder permission settings. Clarify that explicit ERC-8493
onchain:URIs resolve ERC-8048-backed metadata, while arbitrary agent records are not interpreted automatically. Also explain batch permission checks and how holders clear a metadata-policy delegation.Documentation only. Checked against
ERC8048OnchainMetadata,MetadataWriterPolicy, OpenSea'sOnchainUriResolver, and the published metadata-storage guide. CI validates formatting and the existing contract suite; no local tests or Docker runs.