Skip to content

Clarify agent metadata resolution and write permissions - #238

Merged
ryanio merged 1 commit into
mainfrom
ryan/agent-docs-metadata
Nov 17, 2026
Merged

ryanio merged 1 commit into
mainfrom
ryan/agent-docs-metadata

Conversation

@ryanio

@ryanio ryanio commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

The agent guide incorrectly says OpenSea never reads ERC-8048 records and describes batch writes without the owner/holder permission settings. Clarify that explicit ERC-8493 onchain: URIs resolve ERC-8048-backed metadata, while arbitrary agent records are not interpreted automatically. Also explain batch permission checks and how holders clear a metadata-policy delegation.

Documentation only. Checked against ERC8048OnchainMetadata, MetadataWriterPolicy, OpenSea's OnchainUriResolver, and the published metadata-storage guide. CI validates formatting and the existing contract suite; no local tests or Docker runs.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The central claim about OpenSea’s ERC-8493 resolution remains unverified because its resolver and published guide were inaccessible, although local contracts and tests support the permission and delegation wording.

No open issues 🎉

What changed in this PR

This documentation-only PR clarifies metadata resolution and write permissions in SeaDrop’s agent NFT guide. No contract behavior changes.

Changes:

  • Distinguishes explicit ERC-8493 onchain: URI resolution from automatic interpretation of arbitrary ERC-8048 agent records.
  • Clarifies how authority, owner and holder permissions apply to batch writes.
  • Explains delegation behavior across transfers and how current holders clear a delegation.
File Description
docs/​AgentNFTs.md Clarifies OpenSea metadata resolution, batch write permissions and delegation clearing.

Review effort: Balanced

@ryanio

ryanio commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator Author

Verified the resolution claim against the live Metadata storage guide, which returns HTTP 200 and documents both ERC-8048 field reads through onchain: URIs and an onchain: URI returned by tokenURI for the whole JSON document. The backing OnchainUriResolver also implements readDocument and resolve with metadata(tokenId, key). This addresses the external-evidence limitation in Copilot’s review; no additional content change is needed.

@ryanio
ryanio merged commit d88b878 into main Nov 17, 2026
8 checks passed
@ryanio
ryanio deleted the ryan/agent-docs-metadata branch November 17, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants