Fix PXFileParser encoding detection and update tests - #136
Merged
Conversation
JohannesFinsveen
commented
Sep 4, 2026
JohannesFinsveen
commented
Collaborator
- Updated PCAxis.Core.Tests.csproj to always copy Alias_en.txt as content and removed it as a None item.
- Added Alias_en.txt test file with "Environment" content.
- Added GetEncoding_ShouldReadAliasFile test to verify encoding detection.
- Fixed PXFileParser.GetEncoding to return detected encoding.
- Replaced And with AndAlso in PXFileParser.vb for safer logic.
- Updated PCAxis.Core.Tests.csproj to always copy Alias_en.txt as content and removed it as a None item. - Added Alias_en.txt test file with "Environment" content. - Added GetEncoding_ShouldReadAliasFile test to verify encoding detection. - Fixed PXFileParser.GetEncoding to return detected encoding. - Replaced And with AndAlso in PXFileParser.vb for safer logic.
runejo
reviewed
Sep 4, 2026
Updated GetEncoding_ShouldReadAliasFile to use Path.Combine with AppContext.BaseDirectory for test file path construction. Added assertion to verify PXFileParser.GetEncoding returns Encoding.Default.
runejo
approved these changes
Sep 4, 2026
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.