Skip to content

fix: remove stale workspace and assistant prior entries #90

Closed

Description

@Jammy2211

Overview

remove stale workspace and assistant prior entries. One of the five existing configuration tasks approved together in this session.

Plan

Apply the bounded PyAutoGalaxy#618 corrections to each listed config/priors tree, including autogalaxy_workspace_test/scripts/misc/aggregator/config/priors: ersic typo, dead NFWTruncatedMCRScatterLudlowSph key path, orphan linear chameleon/eff files, PointSourceChi, SersicCoreSph.mass_to_light_ratio, linear-operated Gaussian.intensity and obsolete Voronoi README mention. Inspect each full file and current packaged defaults before targeted edits; preserve unrelated overrides. Replace the obsolete fits.flip_for_ds9 with the supported fits setting if present and replace readerless plots_search sampler sections with supported nest/mcmc/mle sections preserving meaningful switches. Keep Euclid untouched. Validate YAML and changed prior keys, instantiate representative models and run applicable smoke checks. No new library behavior.

Tier: glance — merge mode: human review (/prm); no merge authorized.

Detailed implementation plan

Affected repositories: HowToGalaxy, autogalaxy_workspace_test, autolens_assistant, autogalaxy_assistant, autocti_assistant.
Branch: feature/workspace-prior-copies; worktree root: /home/jammy/Code/PyAutoLabs/.worktrees/workspace-prior-copies. For existing contributor PRs, retain their head branches instead.
All canonical checkouts are on main. Existing untracked dataset.fits in autolens_workspace and the schematic PNG in autolens_assistant are excluded. No other session holds registered repo claims; this session coordinates its own overlapping tasks sequentially on isolated branches. The unrelated PyAutoFit detached worktree is untouched.

Key files, changes and validation: Apply the bounded PyAutoGalaxy#618 corrections to each listed config/priors tree, including autogalaxy_workspace_test/scripts/misc/aggregator/config/priors: ersic typo, dead NFWTruncatedMCRScatterLudlowSph key path, orphan linear chameleon/eff files, PointSourceChi, SersicCoreSph.mass_to_light_ratio, linear-operated Gaussian.intensity and obsolete Voronoi README mention. Inspect each full file and current packaged defaults before targeted edits; preserve unrelated overrides. Replace the obsolete fits.flip_for_ds9 with the supported fits setting if present and replace readerless plots_search sampler sections with supported nest/mcmc/mle sections preserving meaningful switches. Keep Euclid untouched. Validate YAML and changed prior keys, instantiate representative models and run applicable smoke checks. No new library behavior.

Acceptance is the original prompt's witness, evaluated against current source; stale reported defects must be identified rather than recreated. Preserve original task scope and separate task/PR identity. No separate bundle backlog.

Original Prompt

Starting prompt

Sync remaining workspace config/priors copies

Type: maintenance
Target: workspaces
Repos:

  • HowToGalaxy
  • autogalaxy_workspace_test
  • autolens_assistant
  • autogalaxy_assistant
  • autocti_assistant
    Difficulty: small
    Autonomy: safe
    Priority: medium
    Status: formalised
    Consequence: glance
    Witness: A diff of every listed config/priors copy (HowToGalaxy, both autogalaxy_workspace_test copies, the three assistants) against the packaged PyAutoGalaxy config/priors shows none of the #618 dead rows (the ersic typo, NFWTruncatedMCRScatterLudlowSph, the orphan chameleon.yaml/eff.yaml, PointSourceChi, SersicCoreSph.mass_to_light_ratio, linear-operated Gaussian.intensity, Voronoi in mesh/README.md), each repo's general.yaml/plots_search.yaml carries the replacements for the readerless keys, and the euclid pipeline copy is untouched.
    Review-minutes: 3
    Unattended: ready

Remaining config/priors copies still carry the drift rows fixed by PyAutoGalaxy#618. PR #619 fixed the packaged autogalaxy/config/priors/ and the workspace PRs on #618 re-synced autolens_workspace, autogalaxy_workspace, HowToLens and autolens_workspace_test. The same dead rows (ersic typo in light/operated/sersic.yaml, NFWTruncatedMCRScatterLudlowSph under nfw_truncated_mcr.yaml, orphan light/linear/chameleon.yaml + eff.yaml, PointSourceChi, SersicCoreSph.mass_to_light_ratio, linear-operated Gaussian.intensity, Voronoi in mesh/README.md) still exist verbatim in: HowToGalaxy/config/priors, autogalaxy_workspace_test/config/priors and its second copy autogalaxy_workspace_test/scripts/misc/aggregator/config/priors, autolens_assistant/config/priors, autogalaxy_assistant/config/priors, autocti_assistant/config/priors. Apply the same edits (as edits, not blind copies; check each repo's general.yaml for the readerless fits.flip_for_ds9 and visualize/plots_search.yaml for the unread per-search dynesty:/emcee:/nautilus:/zeus: form, replace with PyAutoFit's nest/mcmc/mle file). euclid_strong_lens_modeling_pipeline keeps its copy by design (euclid#43). Also note autogalaxy_workspace/config/priors/ellipse/ellipse_multipole.yaml has no EllipseMultipoleScaled block (falls through to the packaged one; informational). Consider a shared parity check that diffs every workspace config/priors against the packaged PyAutoGalaxy copy.

Activity

  1. Jammy2211 commented on Oct 26, 2026

    @Jammy2211
    CollaboratorAuthor

    Applied the remaining #618 prior-copy corrections in five worktrees / six config roots. Independent validation: 496 YAML files pass strict duplicate-key parsing; 54 changed mappings match the intended transformations; all six NFW scatter moves preserve their values; 30/30 model construction and median-instance checks pass. Removed two pre-existing identical duplicate radius_break entries without changing their effective values. HowToGalaxy and autogalaxy_workspace_test smoke is running through Heart's isolated environment API; assistants have isolated model/config checks. Changes remain local pending smoke and shipping gates. Evidence: .worktrees/workspace-prior-copies/logs/prior-validation.md.

  2. Jammy2211 commented on Oct 26, 2026

    @Jammy2211
    CollaboratorAuthor

    Four validated PRs are open for review:

    Assistant roots pass their isolated model/config checks. The fifth repository, autogalaxy_workspace_test, is still undergoing smoke validation and has not been pushed. Nothing merged or closed.

  3. Jammy2211 commented on Oct 26, 2026

    @Jammy2211
    CollaboratorAuthor

    Validation-count correction: HowToGalaxy discovered 39 scripts, but its authoritative JSON report contains 32 executed scripts, all passed; the runner excludes the remaining discovery entries. The earlier comments counted discovery rather than execution. PR #91 now uses the verified count. Exit status remains 0.

  4. Jammy2211 commented on Oct 26, 2026

    @Jammy2211
    CollaboratorAuthor

    Final prior-copy PR: PyAutoLabs/autogalaxy_workspace_test#131 — all 43 Heart regression scripts passed. Together with HowToGalaxy #91 (32 executed scripts passed) and the three assistant PRs linked above, all five repositories now have validated PRs open. No merge/close performed. Independent config/model evidence remains in .worktrees/workspace-prior-copies/logs/prior-validation.md.

  5. Jammy2211 commented on Oct 26, 2026

    @Jammy2211
    CollaboratorAuthor

    Shipped

    Merged HowToGalaxy #91, autogalaxy_workspace_test #131, autolens_assistant #164, autogalaxy_assistant #38 and autocti_assistant #38. Independent validation covered 496 YAML files, 54 intended mapping changes and 30 model checks. HowToGalaxy passed 32 executed scripts; Galaxy regression workspace passed 43. Every workflow run and job was green at merge. Human /prm confirmed merged unchanged and authorized completed-worktree cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions