Repository navigation
Description
Overview
PyAutoArray/files/ holds two experiment scripts from the May rectangular-adapt-cdf spike (ghost_peak_experiment.py, pca_rotation_experiment.py) that import autoarray.inversion.mesh.interpolator.rectangular_spline, a module that no longer exists, plus their notes and plots. Nothing outside files/ references them. Human decision 2026-10-29: delete them.
Plan
- Delete all six files under
PyAutoArray/files/. - No library code, tests or docs change.
- Witness:
files/gone andgit grep -c rectangular_splinereturns 0 (every current hit is insidefiles/). - Runs concurrently with mesh-magnification-areas and cosmos-web-ring-intro-visuals (human-authorized; neither branch touches
files/). - Tier: glance — merge mode: auto-merge on green if the Witness passes, post-merge summary.
Detailed implementation plan
Affected Repositories
- PyAutoArray (primary)
Branch Survey
| Repository | Current Branch | Dirty? |
|---|---|---|
| ./PyAutoArray | main | clean (staged git rm of these files on canonical main was unstaged 2026-10-29 and redone here) |
Suggested branch: feature/files-experiment-scripts-cleanup
Implementation Steps
- Worktree
~/Code/PyAutoLabs-wt/files-experiment-scripts-cleanup/PyAutoArray. git rm -r files/; commit.- Verify witness grep;
pytest test_autoarray -x -qsanity run. - PR → glance merge on green → /prm close-out.
Key Files
files/cdf_audit.md,files/ghost_peak.png,files/ghost_peak_experiment.py,files/ghost_peak_findings.md,files/pca_rotation.png,files/pca_rotation_experiment.py— removed
Original Prompt
Click to expand starting prompt
files/*_experiment.py import a module that no longer exists — decide whether to keep them
Type: maintenance
Target: PyAutoArray
Repos:
- PyAutoArray
Difficulty: small
Autonomy: supervised
Priority: low
Status: formalised
Consequence: glance
Witness: every script underPyAutoArray/files/either imports successfully against the installed stack, or is gone;git grep -c rectangular_splinereturns 0.
Review-minutes: 3
Unattended: ready
The finding
PyAutoArray/files/ghost_peak_experiment.py:51 and files/pca_rotation_experiment.py:40 both do:
from autoarray.inversion.mesh.interpolator.rectangular_spline import (...)
That module does not exist. The live contents of
autoarray/inversion/mesh/interpolator/ are abstract.py, delaunay.py, knn.py,
rectangular.py, rectangular_uniform.py, sibson.py. So both scripts fail at import.
Independently confirmed by the workspace's own PyAuto API gate, which refused an import
attempt with: "STALE autoarray.inversion.mesh.interpolator.rectangular_spline — not in
installed stack (missing .rectangular_spline); closest live names: rectangular".
Provenance
Both were committed with the rectangular-adapt-cdf spike (f9aceea3, f9c6d218) and the
module has since been renamed or removed. Their docstrings still told readers to
source ~/Code/PyAutoLabs-wt/rectangular-adapt-cdf/activate.sh — a task bundle long gone —
which is corroborating evidence that nothing has run them since. Those docstring lines were
corrected in PyAutoBrain#393 (phase 2 of the workspace regroup); the dead import was left
alone as out of scope for a prose fix, and is filed here instead.
Nothing references either file except each other and files/ghost_peak_findings.md.
The decision, which is a human's
Not obviously a bug to fix — the question is whether these spike scripts are still wanted:
- Keep and repair — repoint the import at whichever live module replaced
rectangular_spline(rectangular.py/rectangular_uniform.py), and check the symbols
they import still exist under their new names. Only worth it if the experiments are still
interesting. - Retire — delete both scripts, and decide separately whether
ghost_peak_findings.mdis
a result worth keeping without the script that produced it (it may well be: the finding
outlives the spike).
Do not "fix" them by guessing an import that makes them parse. If they are kept they should
actually run.
Activity
Jammy2211 commentedon Oct 29, 2026
Shipped in #663 (merged ff6d457):
files/removed — six files, 1157 deletions. Witness:git grep -c rectangular_splinereturns 0. CI green on unittest 3.12 / 3.13 / nojax. Glance tier, merged under the human-approved plan.