Repository navigation
feat: add Codex skill discovery from shared instructions - #401
Merged
Merged
Conversation
Agent: Codex; model: GPT-6 Astra
Agent: Codex; model: GPT-6 Astra
Agent: Codex; model: GPT-6 Astra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assistant and workspace skills were not discoverable by Codex. Generate their namespaced adapters from the registered repository inventory while retaining canonical skill bodies and existing Claude discovery names.
Phase 3 of the agent-agnostic setup task; tracked in PyAutoBrain#386.
Scripts Changed
bin/install.sh,bin/project_discovery.py: scoped generation and drift checks, collision checks, and protected-file handling.tests/test_skill_install.py: discovery regression coverage.Validation
release validation incomplete: no rehearsal for current source. Development evidence passes; this is not release approval.A bounded codex-cli 0.155.1
skills/listsmoke discovered all 20 autofit assistant adapters with no errors. This checks discovery, not execution of every skill.Generator changes are in the matching PyAutoBrain branch. The committed consumer adapters resolve within this repository without requiring Brain at runtime. Phase 4 metadata and documentation cleanup is tracked separately in PyAutoBrain#400.
Companion PRs
Related phase: #402
CI follow-up
The first CI run caught hardcoded instance names in discovery and missing clone classifications for generated adapters. The follow-up removes those names and classifies the new Claude command links and namespaced Codex wrappers. Clone-profile tests: 37 passed; the full lensing-assistant boundary passed locally. All newly generated inference-assistant adapters are classified; its 11 pre-existing unclassified script/notebook paths remain outside this change. Merge this Brain PR before the corresponding assistant PRs.
The tenant firewall and scoped discovery drift checks now pass. Independent review verified that newborn clones omit parent Codex wrappers and regenerate their own. Installer tests: 22 passed.
Independent CI-followup review: CLEAN.