Repository navigation
fix: CTIAgg and database examples on multi-dataset (factor-graph) fits #121
Description
Overview
The dataset_1d database examples crash on multi-dataset (factor-graph) fits.
ac.agg.CTIAggreadsfit.instance.cti, but a factor-graph instance holds one child per dataset, sodatabase/examples/models.pyfails withAttributeError.database/examples/samples.pyreads.ction the whole instance.
The per-fit aggregators already handle this structure; CTIAgg was missed. This is cti-upkeep phase 3.
Plan
CTIAggworks for multi-dataset fits: single-dataset fits keep returning oneCTI, factor-graph fits return a list with oneCTIper dataset (the same shape the fit aggregators use). Human-approved API decision.- The database
samples.pyexample indexes the dataset before.ctiand explains why. - The two Witness scripts (with
database/start_here.pyfirst) joinsmoke_tests.txt, so CI runs them. - Tier: glance — merge mode: auto-merge on green if the Witness passes, post-merge summary (PyAutoCTI first, then autocti_workspace)
Detailed implementation plan
Affected Repositories
- PyAutoLabs/PyAutoCTI (primary)
- PyAutoLabs/autocti_workspace
Branch Survey
| Repository | Current Branch | Dirty? |
|---|---|---|
| ./cti/PyAutoCTI | main | clean |
| ./cti/autocti_workspace | main | clean |
Suggested branch: feature/cti-database-examples-drift
Implementation Steps
- PyAutoCTI: move
_cti_list_fromintoautocti/aggregator/abstract.pyand import it infit_dataset_1d.pyandfit_imaging_ci.py.cti.py::_cti_fromreturns_cti_list_from(fit.instance, len(fit.children))for factor-graph fits. Update the docstring and drop the stale "analysis summing" log message. - Tests: a factor-graph case in
test_autocti/aggregator/test_aggregator_cti.pythat fails on main. Then run the full suite serially. - autocti_workspace: fix
scripts/dataset_1d/advanced/database/examples/samples.py, add 3 smoke entries, regenerate the affected notebooks. - Witness: both scripts plus
models.pyend-to-end against the branch; all 8 dataset_1d results/database scripts pass; CI smoke passes.
Key Files
autocti/aggregator/cti.py,abstract.py,fit_dataset_1d.py,fit_imaging_ci.pyautocti_workspace/scripts/dataset_1d/advanced/database/examples/samples.py,smoke_tests.txt
Original Prompt
Click to expand starting prompt
autocti_workspace: the dataset_1d results/database example scripts have drifted
Type: bug
Target: autocti_workspace
Repos:
- autocti
- autocti_workspace
Themes: - cti
- notebooks
Difficulty: large
Autonomy: supervised
Priority: normal
Status: formalised
Consequence: glance
Witness:scripts/dataset_1d/advanced/database/examples/samples.pyandscripts/dataset_1d/results/examples/samples.pyrun end-to-end against the installed autocti (FactorGraphModel instance structure, live plot API), and a minimal smoke workflow runs them in CI.
Review-minutes: 3
Unattended: ready
Epic: cti-upkeep
Phase: 3
Filed: 2026-08-19 (backfilled from git)
Activity
Jammy2211 commentedon Nov 5, 2026
Shipped 2026-11-05
CTIAggreturns oneCTIper dataset forFactorGraphModelfits, and a singleCTIotherwise.object_via_gen_fromnow honours itsinstanceargument. PDF draws and above-weight samples were all silently returning the max-likelihood CTI.Witness passed: all 9 dataset_1d results/database scripts run end-to-end, and smoke passes 6/6 under the smoke and release profiles and in CI. The independent review found LOW-severity items only, all resolved or judged. Glance-tier auto-merge (plan approved 2026-11-05).
Follow-up filed: a PyAutoFit bug where
Samples.with_paths/without_pathsbreak on shared-prior factor-graph fits.🤖 Generated with Claude Code