Repository navigation
analytic_gaussian: amend witness criterion 6 for NO_CHANGE updates (PyAutoFit#1711) - #75
Merged
Merged
Conversation
…yAutoFit#1711) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Criterion 6 of the analytic_gaussian ensemble witness counted SUCCESS updates only, so a factor whose Laplace optimiser converged at its start point (
NO_CHANGE,iter=0, projection accepted, message updated) scored as stale. PyAutoFit#1711 diagnosed the 19/400 wave-1 misses: 13 are NO_CHANGE-only prior factors (legitimate converged updates; closed-form match a 5e-5 / b 2e-5 on seed 140 leg A), 6 are BAD_PROJECTION-only hierarchical factors (the #1405 scatter state, cured byprojection="moments", PyAutoFit#1656). The criterion now counts SUCCESS or NO_CHANGE as a completed update; BAD_PROJECTION-only stays a miss. A dated Log note records it on the project ledger. Library PR: PyAutoFit#1712.Not in this PR: the matching
ensemble_seed.py:160 any_factor_never_succeededchange in the science checkout (outside the workspace; diff handed to the human).🤖 Generated with Claude Code