Repository navigation
fix: search kwarg typos silently ignored in workspace scripts and a graphical test #1693
Description
Overview
The unknown-kwarg WARNING added in A0b (PyAutoFit#1672, released) shows several workspace scripts have always passed misspelled or ignored search kwargs (auto_correlations_settings, nlive to DynestyDynamic, dynamic_delta/delta to DynestyStatic), so the settings shown to users never applied. Launched under --auto (safe, judge).
Plan
- PyAutoFit: drop the stray kwargs in
test_autofit/graphical/hierarchical/test_optimise.py(library first). - autofit_workspace: fix
scripts/searches/mcmc.py(auto_correlation_settings) andnest.py(removenlive=on DynestyDynamic or move it to the right argument); regenerate the two notebooks. - autofit_workspace_test: fix
scripts/searches/{Emcee,Zeus}.py, remove the Drawer NullPaths workaround and its comment. - Witness: run the touched scripts under
PYAUTO_TEST_MODE=1against the installed autofit and show no WARNING. - Three PRs (PyAutoFit → autofit_workspace → autofit_workspace_test); end at PR-open.
Detailed implementation plan
Affected Repositories
- PyAutoFit (primary, library), autofit_workspace, autofit_workspace_test
Branch
feature/search-ext-kwarg-typos; worktree ~/Code/PyAutoLabs-wt/search-ext-kwarg-typos/
Steps
- Grep each repo for the kwarg names; confirm the correct argument names against the installed
autofitsignatures (inspect.signature), not the source checkout. - Edit scripts; regenerate notebooks with the workspace's
generate.py/notebook tooling; diff only the touched cells. - Run
PYAUTO_TEST_MODE=1 python scripts/searches/<script>.pyfor each touched script, capture that nounknown keywordWARNING appears; run the PyAutoFit test file. - PRs with the ship gate cell;
pending-releaseapplies to the PyAutoFit PR.
Heart RED — development-only override
Heart at the door: Heart: RED — Release RED; monitoring RED · 10/100 · 415 unresolved; [red] release validation FAILED (stage integrate); [red] PyAutoHands/workflows/Python Version Matrix: failure; [red] PyAutoHeart/workflows/Release Integrate: failure; [red] PyAutoMind/workflows/Lifecycle Drift: failure (cleared 2026-10-15 evening); [red] PyAutoArray/Tests: red; [red] autofit_workspace_test/Smoke Tests: red; [red] autogalaxy_workspace_test/Smoke Tests: red; [red] autolens_workspace_test/Smoke Tests: red; [red] Release validation: NOT release_ready; [red] Worktree drift; [red] autolens_inference: red; [red] autolens_profiling: red; [red] euclid_strong_lens_modeling_pipeline: red. Live human in session 6ffb59e9 answered AskUserQuestion "Yes, override for development (Recommended)" on 2026-10-15 for this launch. Permitted: commit, push, PR-open. Merge is a separate human act; this never reaches a release.
Original Prompt
Click to expand starting prompt
Search constructor typos silently ignored in workspace scripts (auto_correlations_settings, nlive, dynamic_delta)
Type: bug
Target: autofit
Repos:
- autofit_workspace
- autofit_workspace_test
- PyAutoFit
Themes: - searches
Difficulty: small
Autonomy: safe
Priority: normal
Epic: search-extensibility
Status: formalised
Consequence: judge
Witness: running autofit_workspacescripts/searches/{mcmc,nest}.pyand autofit_workspace_testscripts/searches/{Emcee,Zeus,Drawer}.pyunderPYAUTO_TEST_MODE=1against the installed autofit emits no unknown-kwarg WARNING; the two workspace notebooks are regenerated from the scripts; PyAutoFittest_autofit/graphical/hierarchical/test_optimise.pypasses without the stray kwargs; the Drawer NullPaths workaround is gone.
Filed: 2026-10-08
Symptom
The unknown-kwarg WARNING added in A0b (PyAutoFit#1672) fires on existing scripts, showing that these settings have
always been silently swallowed by **kwargs:
- autofit_workspace
scripts/searches/mcmc.py:108,188and autofit_workspace_testscripts/searches/{Emcee,Zeus}.py:93
passauto_correlations_settings=(the argument isauto_correlation_settings), so the autocorrelation settings
shown to users never applied. - autofit_workspace
scripts/searches/nest.py:106,190passnlive=toDynestyDynamic, which ignores it. test_autofit/graphical/hierarchical/test_optimise.py:12passesdynamic_delta/deltatoDynestyStatic.
Also: autofit_workspace_testscripts/searches/Drawer.pycarries a NullPaths workaround and comment that A0b makes
unnecessary.
Fix
Correct the argument names (regenerate the two workspace notebooks), drop the test's stray kwargs, remove the Drawer
workaround. Verify no WARNING fires when the scripts run under PYAUTO_TEST_MODE=1. Workspace work after #1672 is
released (the warning itself is harmless before then).
Original request (verbatim)
Found by the A0b implementation worker (search-extensibility); no human words yet.
Activity
fix: search kwarg typos in cookbooks/search.py
fix: nlive -> nlive_init for DynestyDynamic in searches/DynestyDynami…
Jammy2211 commentedon Oct 15, 2026
Shipped
Merged 2026-10-15 by human
/prm, library first: PyAutoFit#1695 (7f36e16,pending-release) → autofit_workspace#170 (ade6c54af) → autofit_workspace_test#112 (e81faaf0b). Scope was extended in the same PRs toscripts/cookbooks/search.pyandscripts/searches/DynestyDynamic.py. Shipped under the recorded Heart RED development override; merge a separate human act. Mind record:complete/2026/10/search-ext-kwarg-typos.md.test: drop stray dynamic_delta/delta kwargs passed to DynestyStatic