fix(messages): fix TransformedMessage.factor_gradient unpack and chain-rule logd_jacs accumulation - #1502
Open
trexfr-ops wants to merge 2 commits into
Open
Conversation
…n-rule logd_jacs accumulation
…al to numerical gradient
Author
|
Agreed! I verified the gradient accumulation directly against numerical finite differences across both scalar and multivariate transform compositions in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1501
This PR resolves the crash in
TransformedMessage.factor_gradientwhere it unpacked 4 values fromself._transform_det_jac(x)(which returns 3:(x, logd, logd_jacs)).Changes
factor_gradientinautofit/messages/composed_transform.pyto unpackx, logd, logd_jacs = self._transform_det_jac(x).logd_gradin reverse order:test_autofit/graphical/functionality/test_messages.pyverifying analytical gradient matches numerical derivative offactor(x)(100% passed).💰 Bounty Claim & LTC Payout Address:
LPnftYop8yhRNQZstysT3vuJf3XkpQWKTC