Skip to content

Document configuration leaves and check comment coverage - #1733

Merged
Jammy2211 merged 1 commit into
mainfrom
feature/config-leaf-comments
Oct 26, 2026
Merged

Jammy2211 merged 1 commit into
mainfrom
feature/config-leaf-comments

Conversation

@Jammy2211

@Jammy2211 Jammy2211 commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Document existing configuration leaf values in PyAutoFit with adjacent one-line comments. Parsed YAML values are unchanged.

Add a standalone checker for missing non-prior YAML leaf comments, with four focused regression tests.

API Changes

None — internal changes only.

Test Plan

  • Across all four libraries, the audit reports 277 missing comments on the baseline and zero after the changes.
  • All 125 parsed YAML configuration values are unchanged.
  • Four focused checker tests pass; whitespace checks pass.
  • Full serial PyAutoFit suite: 3,932 passed, 2 skipped, 1 xfailed.
  • Downstream autofit_workspace smoke: 8 scripts and 2 notebooks passed. All eight downstream workspaces now pass (172 checks total).

Draft gate

The human explicitly approved draft PRs with the reproduced baseline PyAutoFit Zeus logging assertion documented. Parallel Fit tests also expose baseline shared-file/SQLite races; failed-node serial rerun passed 27/28, with only that Zeus assertion remaining. The complete serial suite now passes, including Zeus; the isolated failure is order-sensitive baseline behavior. This PR remains draft as requested. Merge is blocked pending human review; the exception does not waive unrelated failures.

Task: #1732

Generated by the PyAutoLabs agent workflow.

Copy link
Copy Markdown
Collaborator Author

Workspace draft PR: PyAutoLabs/autogalaxy_workspace#264. Configuration comments only; values unchanged. Heart smoke passes 14 scripts and 2 notebooks. Library-first merge gate applies.

Copy link
Copy Markdown
Collaborator Author

Workspace draft PR: PyAutoLabs/autolens_workspace#602. Configuration comments only; values unchanged. Heart smoke passes 42 scripts and 2 notebooks. Library-first merge gate applies.

@Jammy2211
Jammy2211 marked this pull request as ready for review October 26, 2026 10:27
@Jammy2211
Jammy2211 merged commit 16b8081 into main Oct 26, 2026
5 checks passed
@Jammy2211
Jammy2211 deleted the feature/config-leaf-comments branch October 26, 2026 10:27
@pyautolabs-bot pyautolabs-bot Bot removed the pending-release PR queued for the next release build label Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant