fix(heart): give the worded copy chips the theme's text modifier - #192
Merged
Conversation
The plan line's "clear them all" and "command chain" buttons carry words, but `button.copy` is a fixed 2.6rem square drawn for a bare glyph. The labels wrapped inside 42px into a one-word-per-line column and spilled out of the box — reported from a laptop as a thin column of text under the gaps heading. Whitespace in the face is the test, because that is what makes a face a phrase rather than a glyph; the per-row glyph buttons keep their square. The `text` rule itself belongs to the family and lives in the shared theme. The regression test asserts per button — this face has words, so this button is a chip — rather than by position, so it survives the board reordering its tiers. Verified red with the modifier removed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018q6ZrgG6u8o8ENYZ7cq3Lr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported from a laptop: under the Evidence gaps heading, clear them all renders as a thin column of text.
The cause
The plan line's two buttons carry words —
📋 clear them alland⌨ command chain— but the family'sbutton.copyis a fixed 2.6rem square drawn for a bare glyph. At 42px wide the label wraps to one word per line and spills out of the box. This is not new: the plan line has shipped this way since the actionable board landed; it took a laptop to notice.The fix
_copy_btnadds the theme'stextmodifier when the face carries words:Whitespace in the face is the test, because that is what makes a face a phrase rather than a glyph. The per-row
📋and⌨buttons keep their square. Thetextrule itself belongs to the family and lands in PyAutoLabs/PyAutoBrain#314 — this PR only opts in, so either order is safe.The regression test
test_a_worded_copy_face_is_a_chip_and_a_glyph_stays_a_squareasserts per button — this face has words, so this button is a chip — rather than by position, so it survives the board reordering its tiers.Verified as a control: with the modifier removed the test goes red (
AssertionError), and green again with it restored. My first draft compared positions of the two class strings and failed for the wrong reason (the plan chips render above the per-row list, so there is no bareclass='copy'before them) — replaced rather than patched.Verification
pytest tests→ 657 passed (656 + the new one).🤖 Generated with Claude Code
https://claude.ai/code/session_018q6ZrgG6u8o8ENYZ7cq3Lr