Repository navigation
feat: keep dataset-only image_with_points.png; after-fit figure → fit_image_with_points.png #781
Description
Overview
Follow-up to #779. The point visualizer writes the dataset-only figure (observed image + observed positions) before the fit and the fit figure (+ model positions + critical curves) after it, but both under image_with_points.png, so the dataset-only version is overwritten and never reaches PyAutoEyes. This renames the after-fit figure to fit_image_with_points.png so both coexist, and shows both in autolens_visualization / PyAutoEyes.
Plan
- PyAutoLens: after-fit figure →
fit_image_with_points.png; dataset-only staysimage_with_points.png; fitplots.yamlkey renamed tofit_image_with_points(unreleased, so safe). - autolens_workspace: docstrings/comments in the six point-source scripts describe both figures.
- autolens_visualization: both point producers keep both figures; gallery 66 → 68.
- PyAutoEyes:
dashboard_refreshafter the viz PR merges (no Eyes PR). - Order: library → workspace → visualization → Eyes refresh.
Tier: judge — merge mode: human /prm
Detailed implementation plan
Affected Repositories
- PyAutoLens (primary)
- autolens_workspace
- autolens_visualization
Branch Survey
| Repository | Current Branch | Dirty? |
|---|---|---|
| lens/PyAutoLens | main | clean |
| lens/autolens_workspace | main | untracked root dataset.fits (not ours) |
| lens/autolens_visualization | main | clean |
Suggested branch: feature/point-image-fit-filename
Implementation Steps
autolens/point/plot/fit_point_plots.pyplot_image_with_points: filenameimage_with_pointswhenfit is None, elsefit_image_with_points. The fit version is retitled "… Fit Image With Points", and the docstring covers dataset-only use before modeling.autolens/config/visualize/plots.yaml:fit_point_dataset.image_with_points→fit_point_dataset.fit_image_with_points.point_dataset.image_with_pointsis unchanged.autolens/point/model/plotter.py: read the renamed fit key.- Tests: before-fit writes only
image_with_points.png; after-fit writesfit_image_with_points.png; both coexist after before_fit + visualize; the dataset-only call draws no Model scatter and no lines. - autolens_workspace
scripts/point_source/{modeling,features/fluxes,features/time_delays,features/extra_galaxies/modeling,features/scaling_relation/modeling}.py: describe both figures. Regenerate notebooks and smoke-test. - autolens_visualization: producers
extra_pngs=("image_with_points.png", "fit_image_with_points.png"), updated docstrings. Re-run producers +gallery_build(+--check).
Key Files
autolens/point/plot/fit_point_plots.py,autolens/point/model/plotter.py,autolens/config/visualize/plots.yamlautolens_visualization/scripts/point_source_{image,source}_chi_squared/visualization.py
Original Prompt
Click to expand starting prompt
ok, can I check we also have a dataset-only version of this which does not include model points or critical curves? It should be an option (E.g. for display before lens modeling). This model image is good thiugh, albeit the filename should prob be model_image_with_points.png
Decision (human, 2026-10-21): after-fit name fit_image_with_points.png; keep both figures in Eyes.
Activity
Jammy2211 commentedon Oct 21, 2026
Library PR Created: #782 (843 passed, 1 xfailed). Workspace: PyAutoLabs/autolens_workspace#592. Visualization: PyAutoLabs/autolens_visualization#7. Heart YELLOW was acknowledged by the human. Judge tier: human /prm, library first; then the Eyes refresh.
Jammy2211 commentedon Oct 21, 2026
Shipped — 2026-10-21
Merged by human
/prm, library first:fit_image_with_points.png, so the dataset-onlyimage_with_points.png(observed positions only, for display before lens modeling) is kept. Fitplots.yamlkey renamed tofit_image_with_points. Pending release (with feat: overlay point-source positions on a dataset image #780).ruff format; a formatting-only commit, human-approved, made it green.dashboard_refreshrun 39591165754 (commit a4cc7da). The board listsimage_with_points.pngandfit_image_with_points.pngfor both point domains.