Repository navigation
test: repin Isothermal clamp-artefact pins (companion to PyAutoGalaxy#631) - #754
Merged
Merged
Conversation
Companion to PyAutoLabs/PyAutoGalaxy#631, which removes the clamp; the new values are the exactly-circular result. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to PyAutoLabs/PyAutoGalaxy#631. Its PR removes the elliptical
Isothermalaxis_ratio <= 0.99999clamp, and this PR repins the 6 tests that had pinned that clamp's artefact (q = 0.99999 at angle 0) instead of a round lens.Forcing
ell_comps=(0, 5e-6), i.e. the old clamped q at angle 0, reproduces every old pin under the new code (34/34 tests in the three files). The same q at another orientation fails them. So the pins encoded the clamp's orientation rather than physics. The new values are the exactly-circular result:Isothermal(0, 0)equalsIsothermalSphto 5e-15.API Changes
None — internal changes only (test pins).
Test Plan
test_autolens: 762 passed, 1 xfailed (with the PyAutoGalaxy branch)pytest.approxin the 6 tests was recorded, not only the first failing assert (the delaunay test had 5 more moved asserts)test_result.pyknife-edge comments are updated (PyAutoLens#721 pointer kept)Repinned literals
analysis/test_result.py:positions_threshold_from0.0019534291 → 0.00098983199 (factor 5: 0.0097671455155 → 0.0049491599483);mass_centre_radial_distance_minpositions swap branch/orderimaging/test_simulate_and_fit_imaging.py: pixelization,__sub_2anddelaunay_splitreconstruction / figure_of_merit / model-image pinsinterferometer/test_simulate_and_fit_interferometer.py: pixelization reconstruction (10 values); figure_of_merit unchangedGenerated by the PyAutoLabs agent workflow.
🤖 Generated with Claude Code