Repository navigation
fix: stop hiding arXiv API failures in paper ref backfill - #103
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scripts/arxiv_refs.pycurrently catches every lookup exception and returnsNone. Downstream,Nonemeans a genuine empty/ambiguous arXiv result, so 406/429/DNS failures are logged as ordinary "no unique match" outcomes and the nightly Action stays green.That is exactly what happened during the same arXiv outage that stopped the upstream paper feeds: PyAutoMemory's ref-backfill workflow looked healthy while resolving nothing.
Fix
urllibreceives the known Fastly 406, retry the request immediately throughcurlbefore spending the backoff ladder.ArxivAPIError;Nonenow only means arXiv answered and there was no unique exact-title match.api_failedseparately in the backfill.NOTE-mark a line when its lookup failed because of transport.Tests
This is the PyAutoMemory-side companion to PyAutoMind #432; it is not the cause of the stale daily inbox stamp, but it removes the silent failure mode exposed by the same incident.