Repository navigation
feat(board): the footer reads the canonical board family, not a tuple in here - #88
Merged
Merged
Conversation
… in here `BOARD_FAMILY` was written before the Cortex had a board, so this page's footer linked five siblings in an ad-hoc order and silently missed the sixth. Membership and order are not this file's to decide: they live once, in the Brain's `config/policy.yaml` `board: boards:`, and the shared theme now offers `board_links` as the one read of it. The tuple stays as the fallback for an older PyAutoBrain checkout whose theme predates the helper, and stays deliberately the OLD list — a fallback that guessed at the current one would drift exactly the way this one did. The owner still comes from the snapshot. tests/test_board.py pins the canonical chip order, that the page never links itself, and that the fallback still renders a footer. Refs #87 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GnXNPigN6qWxLZy2cqhDBX
Collaborator
Author
|
CI is red on exactly the expected leg, and only that one: Merge PyAutoLabs/PyAutoBrain#353 first; re-run here and it goes green. Every other test in this repo passes. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87
The footer had its own copy of the family, and it drifted
scripts/board.pycarried a hard-codedBOARD_FAMILYtuple. It was written beforePyAutoCortex had a board, so this page's footer linked five siblings in an
ad-hoc order and silently missed the sixth. A copy that drifts still renders,
which is why nobody noticed.
Membership and order are not this file's to decide. They live once, in the
Brain's
config/policy.yamlboard: boards:— brain, mind, cortex, memory,heart, hands, organism, the ruled organ order — and the shared theme now offers
_theme.board_links(base, current)as the one read of it. This rendereralready imports that theme via its
theme()locator, and CI here alreadychecks PyAutoBrain out beside the repo, so nothing new has to be reached for.
The tuple stays as the fallback for an older PyAutoBrain checkout whose
theme predates the helper — and stays deliberately the old list, because a
fallback that guessed at the current one would drift exactly the way this one
did. The base URL is still derived here (the snapshot owner).
Branch dependency (library-first)
Depends on PyAutoLabs/PyAutoBrain#353 (
feature/board-family-helper),which adds
_theme.board_links. CI here checks out PyAutoBrainmain, sothe new footer-order assertions only go green once that PR has merged —
until then the fallback path runs and reports the old five-chip order. Merge
PyAutoBrain#353 first.
Tests
python3 -m pytest tests/ -q— 172 passedFooter chip order in the rendered
<ul class="boards">(with the Brainbranch as
PYAUTO_BRAIN):🤖 Generated with Claude Code
https://claude.ai/code/session_01GnXNPigN6qWxLZy2cqhDBX