Ship the HowTo setup_notebook audit: record it complete - #211
Merged
Conversation
The prompt advances draft/bug/howto/ -> active/: the audit has been run and the fix pushed as branches in six repos, so it is in flight rather than not started. The audit itself is recorded in the prompt file. Every .py under scripts/ (plus each HowTo repo's root start_here.py) was checked across the three HowTo repos and all five user-facing workspaces; 39 scripts were missing the setup_notebook() line and all 39 are fixed, with the matching generated notebook updated. autocti_workspace was already clean. autoreduce_workspace and the *_workspace_test / *_workspace_developer repos are out of scope and the prompt says why: none of them generates notebooks, so the convention does not apply there yet. No issue was filed and no PR opened — the registry entry says so and names the branch and per-repo commit, so whoever picks it up knows exactly what is and is not on main. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126SmBwHMzP4okcjhjPoLFZ
The entry was written before the PRs existed and said so. They are open now, so it names them instead: HowToFit#45, HowToGalaxy#66, HowToLens#70, autofit_workspace#138, autogalaxy_workspace#211, autolens_workspace#485. Also records why the three workspace legs are not behind the library-first merge gate: setup_notebook is long-shipped in the released libraries and is already called by every other example script in those repos, so there is no unreleased API for a pending-release label to guard. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126SmBwHMzP4okcjhjPoLFZ
All six PRs merged 2026-08-18 with every check green, so the prompt advances active/ -> complete/2026/08/howto-setup-notebook-audit.md and its active.md entry is removed. lifecycle check + index check both pass; dashboard regenerated. The record keeps what the next person would otherwise re-derive: that the omissions were not a per-subtree policy (siblings in the same directory carry the line), that autoreduce_workspace and the *_test / *_developer repos are out of scope because none of them generates notebooks, the two placement forms plus the one import-first outlier, and the CRLF file in HowToFit that turns a naive mechanical sweep into a 547-line whitespace diff. Two findings are logged as unclaimed rather than silently fixed: fifteen start_here.ipynb files across the two big workspaces carry JSON formatting that differs from the generator's output, and the sibling regeneration-drift task stays open as a separate failure. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126SmBwHMzP4okcjhjPoLFZ
Jammy2211
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bookkeeping for the
setup_notebook()audit, now that all six code PRs are merged. The prompt runs the full lifecycle in this branch —draft/bug/howto/→active/→complete/2026/08/howto-setup-notebook-audit.md— with itsactive.mdentry removed, percomplete/AGENTS.md(the dated record is the ledger).scripts/lifecycle.py checkandlifecycle.py index --checkboth pass;complete/index.mdanddashboard.mdregenerated.The audit
Every
.pyunderscripts/— plus each HowTo repo's rootstart_here.py— checked across the three HowTo repos and all five user-facing workspaces. 39 scripts were missing the line, all fixed and merged:1a4e7132d973bc57e0fbdf61fa55c43847227c79c5960f69Every check green on all six.
What the record keeps
Things the next person would otherwise re-derive:
autolens_workspace/scripts/cluster/has 6 without and 5 with) — a missing line is not a deliberate exemption.autoreduce_workspacehas 30 scripts and none carry the line, which looks alarming until you notice it has nonotebooks/directory. Same for every*_workspace_test/*_workspace_developerrepo (verified by tree listing). Nothing generates notebooks there, so the convention doesn't apply yet.HowToFit/scripts/chapter_1_introduction/tutorial_1_models.pyis committed CRLF while everything around it is LF; a naive read/split/write turns it into a 547-line whitespace-only diff.jax_wrapper) and the one import-first outlier.generate.pyrun should be a no-op; that's the first thing to check if it isn't.Logged as unclaimed, not silently fixed
start_here.ipynbfiles (nine in autolens_workspace, six in autogalaxy_workspace) carry JSON formatting that differs from the generator'sindent=1output. Pre-existing, flagged in both PR bodies, untouched.draft/maintenance/workspaces/notebook_setup_notebook_drift_siblings.mdstays open — notebooks carrying the commented form are a different failure.