Skip to content

prompt: autofit-plot-functions-kwargs shipped (PyAutoFit#1524) - #302

Merged
Jammy2211 merged 7 commits into
mainfrom
claude/autofit-plot-functions-kwargs-vvwj5x
Aug 24, 2026
Merged

prompt: autofit-plot-functions-kwargs shipped (PyAutoFit#1524)#302
Jammy2211 merged 7 commits into
mainfrom
claude/autofit-plot-functions-kwargs-vvwj5x

Conversation

@Jammy2211

Copy link
Copy Markdown
Collaborator

Summary

Mind state for the autofit-plot-functions-kwargs task, from intake through close-out. The code shipped in PyAutoLabs/PyAutoFit#1524 (merged 56f1b87) and PyAutoLabs/autofit_workspace#148 (merged 5056fa3); issue PyAutoLabs/PyAutoFit#1523 is closed.

This session ran on a feature branch rather than pushing Mind to main directly, so the lifecycle commits need this PR to land.

What's in it

  • draft/bug/autofit/plot_functions_discard_kwargs.mdactive/complete/2026/08/autofit-plot-functions-kwargs.md (via lifecycle.py record, prompt folded in under ## Original prompt)
  • active.md — task registered, advanced through library-devready-to-shiplibrary-shipped, then released by the record
  • complete/index.md — regenerated (1120 records)
  • dashboard.md / dashboard.html — regenerated via pyauto-brain intake --apply dashboard

lifecycle.py check → OK. lifecycle.py index --check → OK.

Why the record is worth reading

Two findings generalise beyond this task:

  • corner.corner has its own **kwargs sink. Unrecognised names reach hist2d(**kwargs), whose body reads only extent and drops the rest. So "just forward **kwargs" would not have fixed the tutorials — 18 of their 76 kwargs would have stayed silently ignored one layer deeper. Validating against named parameters only is what closes it, and that shape recurs for any wrapper over a library with a **kwargs sink.
  • weight_list= vs weights=. corner_cornerpy passed a name corner does not have, so every weighted corner posterior had been rendering unweighted — silently, for as long as that call existed. Found by reading corner's real signature rather than trusting the call site.

The record also carries the traps (anesthetic's figsize arriving through **fig_kw, @log_plot_exception swallowing TypeError, monkeypatching breaking signature validation), two follow-ups left deliberately undone, and a sizing calibration note — the Brain bug agent and sizing faculty both scored this too-large (13) and advised phasing; the override was correct.


Generated by Claude Code

Claude and others added 7 commits August 24, 2026 20:44
…ibrary

Issue PyAutoFit#1523 filed for the `autofit.plot` silent-**kwargs defect.
Prompt advances draft/bug/autofit/ → active/; task registered in active.md
as library-dev claiming PyAutoFit + autofit_workspace.

Fix direction approved by the human: forward **kwargs with a strict signature
filter, so unrecognised names raise TypeError instead of vanishing into
corner's hist2d sink. Scope extended to a second silent defect found while
verifying — corner_cornerpy passes weight_list= to corner.corner, which has
no such parameter (it is weights), so sample weights are ignored on every
weighted corner plot.

Brain bug agent and the sizing faculty both scored the prompt too-large (13)
and advised phasing; overridden deliberately and recorded on the issue.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G8EXazf2FEqf4S9UpTwMGV
…e.md

web-github session, so no local worktree: the claim records the clones and
the py3.12 venv instead. Branches created in both repos.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G8EXazf2FEqf4S9UpTwMGV
Status advances to ready-to-ship. PyAutoFit 8cdcff3 and the paired
autofit_workspace commit are on claude/autofit-plot-functions-kwargs-vvwj5x in
each repo; no PRs opened yet.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G8EXazf2FEqf4S9UpTwMGV
Library PR PyAutoFit#1524 and paired workspace PR autofit_workspace#148 both
open and labelled pending-release. Status advances to library-shipped,
workspace-pending; the workspace PR waits on the library-first merge gate.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G8EXazf2FEqf4S9UpTwMGV
PyAutoFit#1524 merged as 56f1b87 and autofit_workspace#148 as 5056fa3, in
library-first order; both branches proven merged before recording. Issue #1523
closed.

Prompt advances active/ -> complete/2026/08/autofit-plot-functions-kwargs.md.
The record keeps the two findings worth carrying: corner.corner's own **kwargs
sink (which is why plain forwarding would not have fixed the tutorials), and
the weight_list=/weights= defect that had every weighted corner posterior
rendering unweighted.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G8EXazf2FEqf4S9UpTwMGV
Resolves the three-way conflict on the generated pages. main had moved 14
commits ahead (PyAutoBrain#267/#269 close-out plus the dashboard self-heal),
and both sides had regenerated complete/index.md, dashboard.md and
dashboard.html from different record sets.

All three conflicts were in GENERATED files, so none was hand-resolved: took
main's side and re-ran the generators over the merged tree --
lifecycle.py index --apply (1122 records: main's 1121 plus this branch's
autofit-plot-functions-kwargs) and pyauto-brain intake dashboard --apply
(140 prompts). The curated Highlights band in index.md survived, as its
markers intend.

This branch's own content is untouched: the completion record stands and its
draft prompt stays folded out.

Verified on the merged tree: lifecycle check OK, index --check OK,
repos_sync --check all 11 legs OK, no conflict markers.

Merged rather than rebased -- this branch belongs to another session and its
pushed history is not rewritten.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MPhEXMoPYa7H1sNHWR2GNW
The Dashboard Refresh check failed on the merge commit even though the pages
had just been regenerated. Cause: this session's PyAutoBrain checkout was 37
commits behind origin/main, so every render used a stale renderer AND a stale
config/policy.yaml. The dashboard census classifies prompts through
repo_aliases, which PyAutoBrain#268/#271 changed, and the renderer itself
gained the freshness banner and refresh block in #265 -- so CI, which runs the
renderer from PyAutoBrain main, correctly saw the committed pages as stale.

Fast-forwarded the Brain checkout to origin/main and re-ran
`intake dashboard --apply`. `dashboard --check` now reports the pages current
against the same renderer CI uses.

lifecycle check OK, index --check OK, repos_sync --check 0 mismatches.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MPhEXMoPYa7H1sNHWR2GNW
@Jammy2211
Jammy2211 merged commit 2961b92 into main Aug 24, 2026
2 checks passed
@github-actions
github-actions Bot deleted the claude/autofit-plot-functions-kwargs-vvwj5x branch August 25, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant