Skip to content

fix: install finufft in Array-based Colab bootstraps - #205

Merged
Jammy2211 merged 1 commit into
mainfrom
feature/colab-finufft-bootstrap
Oct 25, 2026
Merged

Jammy2211 merged 1 commit into
mainfrom
feature/colab-finufft-bootstrap

Conversation

@Jammy2211

Copy link
Copy Markdown
Collaborator

Summary

Colab installs use --no-deps, so AutoArray’s new finufft dependency was omitted and install verification F failed. Install finufft>=2.4.0 for Galaxy/Lens and their HowTo setups, matching AutoArray’s Linux floor. Fit-only setups remain unchanged. Tracks #204.

API Changes

autonerves.setup_colab.setup() installs the CPU NUFFT dependency for Array-based projects. No signatures or notebook call sites change. See full details below.

Test Plan

  • Six-project bootstrap witness: before fix 4 failed / 2 passed.
  • Patched Nerves full suite: 258 passed, 1 existing skip (specifier comparison needs absent Fit/Galaxy sibling checkouts).
  • Existing AutoArray CPU NUFFT parity: 7 passed (finufft 2.5.1, nufftax 0.6.1).
  • Diff whitespace clean; exact published tree matches locally tested files.
  • Required Python 3.12 / 3.13 GitHub CI.
  • After separately approved merge: fresh candidate wheels, real install verification F and release integration; reconcile original Heart IDs. No Colab/wheel integration success is claimed from mocked command tests.
Full API Changes (for automation & release notes)

Changed Behaviour

  • autonerves.setup_colab.setup(project, ...): Array-based project pip commands explicitly include finufft>=2.4.0 under --no-deps.

Migration

  • No notebook edits or user-call changes needed. Existing callers receive the corrected dependency installation after updating Nerves.

Heart RED corrective-PR authorization

James approved this specific PR scope in the current session: authorization record.

Exact approved reason: install verification FAILED (testpypi; checks F). Published Heart timestamp rechecked: 2026-10-25T09:34:29.845384+00:00 (RED).

Reason → #204 → missing dependency in the explicit bootstrap → package-list correction plus six-project command witness. This PR addresses that causal defect; it does not claim official clearance. Sibling release validation FAILED (stage integrate) remains until fresh validation passes. No thresholds, accepted-missing exceptions, scoring weights or test gates changed.

Tier: judge — human /prm. Authorization permits commit, push and this one pending-release PR only. Merge, issue close, release and rehearsal are not authorized. Workspace impact: existing notebook callers need no migration; actual Colab validation remains part of the release-evidence follow-up.

Generated by the PyAutoLabs agent workflow.

@Jammy2211 Jammy2211 added the pending-release PR queued for the next release build label Oct 25, 2026 — with ChatGPT Codex Connector
@Jammy2211
Jammy2211 merged commit ec8b5c1 into main Oct 25, 2026
4 checks passed
@Jammy2211
Jammy2211 deleted the feature/colab-finufft-bootstrap branch October 25, 2026 16:14
@pyautolabs-bot pyautolabs-bot Bot removed the pending-release PR queued for the next release build label Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant